Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1143973003: Reduce new space size during idle times only in memory mode after scavenge, full gc, or finalized i… (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce new space size during idle times only in memory mode after scavenge, full gc, or finalized incremental full gc. BUG= Committed: https://crrev.com/2b8a40e156f832f785ee6d076e01bc8f6c8fb51d Cr-Commit-Position: refs/heads/master@{#28552}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +13 lines, -4 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-21 12:25:43 UTC) #2
ulan
https://codereview.chromium.org/1143973003/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1143973003/diff/20001/src/heap/heap.cc#newcode4570 src/heap/heap.cc:4570: (action.type == DO_SCAVENGE || action.type == DO_FULL_GC || what ...
5 years, 7 months ago (2015-05-21 12:29:31 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1143973003/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1143973003/diff/20001/src/heap/heap.cc#newcode4570 src/heap/heap.cc:4570: (action.type == DO_SCAVENGE || action.type == DO_FULL_GC || On ...
5 years, 7 months ago (2015-05-21 12:31:08 UTC) #4
ulan
lgtm
5 years, 7 months ago (2015-05-21 12:32:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143973003/20001
5 years, 7 months ago (2015-05-21 12:33:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 13:09:40 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 13:09:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b8a40e156f832f785ee6d076e01bc8f6c8fb51d
Cr-Commit-Position: refs/heads/master@{#28552}

Powered by Google App Engine
This is Rietveld 408576698