Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_login_handler.h

Issue 1143963002: Split NTPLoginHandler across chrome://apps and chrome://history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lower Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_login_handler.h
diff --git a/chrome/browser/ui/webui/ntp/ntp_login_handler.h b/chrome/browser/ui/webui/ntp/ntp_login_handler.h
deleted file mode 100644
index d8579f670d40e77ef38d1c5c180657386269f402..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/webui/ntp/ntp_login_handler.h
+++ /dev/null
@@ -1,72 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_UI_WEBUI_NTP_NTP_LOGIN_HANDLER_H_
-#define CHROME_BROWSER_UI_WEBUI_NTP_NTP_LOGIN_HANDLER_H_
-
-#include "base/prefs/pref_member.h"
-#include "chrome/browser/profiles/profile_info_cache_observer.h"
-#include "content/public/browser/web_ui_message_handler.h"
-
-class Profile;
-
-// The NTP login handler currently simply displays the current logged in
-// username at the top of the NTP (and update itself when that changes).
-// In the future it may expand to allow users to login from the NTP.
-class NTPLoginHandler : public content::WebUIMessageHandler,
- public ProfileInfoCacheObserver {
- public:
- NTPLoginHandler();
- ~NTPLoginHandler() override;
-
- // WebUIMessageHandler implementation:
- void RegisterMessages() override;
-
- // ProfileInfoCacheObserver implementation:
- void OnProfileAuthInfoChanged(const base::FilePath& profile_path) override;
-
- // Returns true if the login handler should be shown in a new tab page
- // for the given |profile|. |profile| must not be NULL.
- static bool ShouldShow(Profile* profile);
-
- // Registers values (strings etc.) for the page.
- static void GetLocalizedValues(Profile* profile,
- base::DictionaryValue* values);
-
- private:
- // User actions while on the NTP when clicking on or viewing the sync promo.
- enum NTPSignInPromoBuckets {
- NTP_SIGN_IN_PROMO_VIEWED,
- NTP_SIGN_IN_PROMO_CLICKED,
- NTP_SIGN_IN_PROMO_BUCKET_BOUNDARY,
- };
-
- // Called from JS when the NTP is loaded. |args| is the list of arguments
- // passed from JS and should be an empty list.
- void HandleInitializeSyncLogin(const base::ListValue* args);
-
- // Called from JS when the user clicks the login container. It shows the
- // appropriate UI based on the current sync state. |args| is the list of
- // arguments passed from JS and should be an empty list.
- void HandleShowSyncLoginUI(const base::ListValue* args);
-
- // Records actions in SyncPromo.NTPPromo histogram.
- void RecordInHistogram(int type);
-
- // Called from JS when the sync promo NTP bubble has been displayed. |args| is
- // the list of arguments passed from JS and should be an empty list.
- void HandleLoginMessageSeen(const base::ListValue* args);
-
- // Called from JS when the user clicks on the advanced link the sync promo NTP
- // bubble. Use use this to navigate to the sync settings page. |args| is the
- // list of arguments passed from JS and should be an empty list.
- void HandleShowAdvancedLoginUI(const base::ListValue* args);
-
- // Internal helper method
- void UpdateLogin();
-
- BooleanPrefMember signin_allowed_pref_;
-};
-
-#endif // CHROME_BROWSER_UI_WEBUI_NTP_NTP_LOGIN_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698