Split NTPLoginHandler across chrome://apps and chrome://history.

chrome/browser/ui/webui/app_launcher_login_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_UI_WEBUI_NTP_NTP_LOGIN_HANDLER_H_
-#define CHROME_BROWSER_UI_WEBUI_NTP_NTP_LOGIN_HANDLER_H_
+#ifndef CHROME_BROWSER_UI_WEBUI_APP_LAUNCHER_LOGIN_HANDLER_H_
+#define CHROME_BROWSER_UI_WEBUI_APP_LAUNCHER_LOGIN_HANDLER_H_
 
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_member.h"
-#include "chrome/browser/profiles/profile_info_cache_observer.h"
 #include "content/public/browser/web_ui_message_handler.h"
 
 class Profile;
+class ProfileInfoWatcher;
 
-// The NTP login handler currently simply displays the current logged in
+// The login handler currently simply displays the current logged in
 // username at the top of the NTP (and update itself when that changes).
 // In the future it may expand to allow users to login from the NTP.
-class NTPLoginHandler : public content::WebUIMessageHandler,
-                        public ProfileInfoCacheObserver {
+class AppLauncherLoginHandler : public content::WebUIMessageHandler {
  public:
-  NTPLoginHandler();
-  ~NTPLoginHandler() override;
+  AppLauncherLoginHandler();
+  ~AppLauncherLoginHandler() override;
 
   // WebUIMessageHandler implementation:
   void RegisterMessages() override;
 
-  // ProfileInfoCacheObserver implementation:
-  void OnProfileAuthInfoChanged(const base::FilePath& profile_path) override;
-
   // Returns true if the login handler should be shown in a new tab page
   // for the given |profile|. |profile| must not be NULL.
   static bool ShouldShow(Profile* profile);
 
   // Registers values (strings etc.) for the page.
   static void GetLocalizedValues(Profile* profile,
                                  base::DictionaryValue* values);
 
  private:
   // User actions while on the NTP when clicking on or viewing the sync promo.
@@ skipping 20 matching lines @@
   void HandleLoginMessageSeen(const base::ListValue* args);
 
   // Called from JS when the user clicks on the advanced link the sync promo NTP
   // bubble. Use use this to navigate to the sync settings page. |args| is the
   // list of arguments passed from JS and should be an empty list.
   void HandleShowAdvancedLoginUI(const base::ListValue* args);
 
   // Internal helper method
   void UpdateLogin();
 
-  BooleanPrefMember signin_allowed_pref_;
+  scoped_ptr<ProfileInfoWatcher> profile_info_watcher_;

[MAD, 2015/05/20 19:33:02]

Maybe add the same comment you added to the history handler for this?

[Dan Beam, 2015/05/20 21:53:23]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(AppLauncherLoginHandler);
 };
 
-#endif  // CHROME_BROWSER_UI_WEBUI_NTP_NTP_LOGIN_HANDLER_H_
+#endif  // CHROME_BROWSER_UI_WEBUI_APP_LAUNCHER_LOGIN_HANDLER_H_