Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tool/input_sdk/private/js_helper.dart

Issue 1143953004: Fixes for sunflower (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/input_sdk/private/js_helper.dart
diff --git a/tool/input_sdk/private/js_helper.dart b/tool/input_sdk/private/js_helper.dart
index e36c37147609e160a50a147cf2e8dead981811ba..6082b11fee2ec9312887c84375f263c3009d9fcd 100644
--- a/tool/input_sdk/private/js_helper.dart
+++ b/tool/input_sdk/private/js_helper.dart
@@ -582,7 +582,7 @@ class Primitives {
return JS('int', '#', hash);
}
- static _throwFormatException(String string) {
+ static Null _throwFormatException(String string) {
vsm 2015/05/26 13:40:58 This feels a bit strange, but see the casts in the
Leaf 2015/05/26 18:19:45 This is a bit odd. I don't understand why Null he
vsm 2015/05/27 13:37:21 Ugh, it turns out that we were reporting an error
Leaf 2015/05/27 22:16:34 I don't understand this either... :} I don't thin
throw new FormatException(string);
}

Powered by Google App Engine
This is Rietveld 408576698