Filter spurious mouse move events.

Filter spurious mouse move events.

Due to crbug.com/489468, detection of re-written key combinations
(e.g. Search+Backspace->Delete) were being mis-treated as modifier
key combinations (i.e. Search+Backspace->Search+Delete).

Since the spurious mouse event causing this has the same x and y
coordinates as the previous mouse event, it can be filtered to
suppress the unwanted keyboard event.

BUG=484329
Committed: https://crrev.com/7732b72f6f4b61d3e00b17049ec2a57a0f3e80f7
Cr-Commit-Position: refs/heads/master@{#330829}

[Jamie, 2015-05-20 00:59:52]

jamiewalch@chromium.org changed reviewers:
+ wez@chromium.org

[Jamie, 2015-05-20 00:59:53]

ptal

[Wez, 2015-05-20 18:52:33]

On 2015/05/20 00:59:53, Jamie wrote:
> ptal

nit: CL description says "due to crbug...", where the bug referred to is just
describing that same behaviour - it's not a bug that describes a cause for that
behaviour.  I'd suggest rewording to "Due to crbug... detection of re-written
key combinations (e.g. Search+Backspace->Delete) were being mis-treated as
modifier key combinations (i.e. Search+Backspace->Search+Delete)."

You also mention this affecting Alt+Backspace, but IIRC the CrOS rewriting key
work-arounds don't apply to Alt (yet)?

[Wez, 2015-05-20 19:00:27]

https://codereview.chromium.org/1143943002/diff/1/remoting/client/plugin/norm...
File remoting/client/plugin/normalizing_input_filter_cros.cc (right):

https://codereview.chromium.org/1143943002/diff/1/remoting/client/plugin/norm...
remoting/client/plugin/normalizing_input_filter_cros.cc:128: event.y() !=
previous_mouse_y_)) {
I'd prefer you break this into two ifs - the existing deferred keydown check and
then the second if, with a comment referencing the bug that we're working
around, so that we can remove the hack if PPAPI/Blink/whatever ever gets fixed.

[Jamie, 2015-05-20 19:35:32]

ptal

[Jamie, 2015-05-20 19:36:02]

https://codereview.chromium.org/1143943002/diff/1/remoting/client/plugin/norm...
File remoting/client/plugin/normalizing_input_filter_cros.cc (right):

https://codereview.chromium.org/1143943002/diff/1/remoting/client/plugin/norm...
remoting/client/plugin/normalizing_input_filter_cros.cc:128: event.y() !=
previous_mouse_y_)) {
On 2015/05/20 19:00:27, Wez wrote:
> I'd prefer you break this into two ifs - the existing deferred keydown check
and
> then the second if, with a comment referencing the bug that we're working
> around, so that we can remove the hack if PPAPI/Blink/whatever ever gets
fixed.

Done.

[Wez, 2015-05-20 21:19:43]

The CQ bit was checked by wez@chromium.org

[Wez, 2015-05-20 21:19:44]

lgtm

[commit-bot: I haz the power, 2015-05-20 21:21:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143943002/20001

[commit-bot: I haz the power, 2015-05-20 23:07:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-20 23:08:46]

Patchset 2 (id:??) landed as
https://crrev.com/7732b72f6f4b61d3e00b17049ec2a57a0f3e80f7
Cr-Commit-Position: refs/heads/master@{#330829}