Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1143923003: Remove SK_PREFER_LEGACY_FLOAT_XFERMODES (Closed)

Created:
5 years, 7 months ago by f(malita)
Modified:
5 years, 7 months ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SK_PREFER_LEGACY_FLOAT_XFERMODES R=reed@google.com,mtklein@google.com BUG=490188 Committed: https://crrev.com/cdc1058ced5c34bb234f331ec99028a02cca3703 Cr-Commit-Position: refs/heads/master@{#330779}

Patch Set 1 #

Patch Set 2 : suppressions #

Patch Set 3 : updated suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 2 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
f(malita)
Test run to assess the layout test impact.
5 years, 7 months ago (2015-05-20 14:53:11 UTC) #1
mtklein_C
lgtm
5 years, 7 months ago (2015-05-20 16:12:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143923003/40001
5 years, 7 months ago (2015-05-20 18:34:21 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 18:53:43 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 18:54:36 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cdc1058ced5c34bb234f331ec99028a02cca3703
Cr-Commit-Position: refs/heads/master@{#330779}

Powered by Google App Engine
This is Rietveld 408576698