Issue 1143913003: Convert DCHECK validating that |request_id| was found to a CHECK in SpeechRecognitionDispatcher.

Issue 1143913003: Convert DCHECK validating that |request_id| was found to a CHECK in SpeechRecognitionDispatcher. (Closed)

Created:
5 years, 7 months ago by Martin Barbella

Modified:
5 years, 7 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Convert DCHECK validating that |request_id| was found to a CHECK in SpeechRecognitionDispatcher. BUG=470777 Committed: https://crrev.com/324a169646a722c4be1e222b3bb053c46a65956e Cr-Commit-Position: refs/heads/master@{#330660}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/speech_recognition_dispatcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Martin Barbella

Charlie, could you PTAL? Prepared this based on https://code.google.com/p/chromium/issues/detail?id=470777#c16, though it does seem like it ...

5 years, 7 months ago (2015-05-19 23:26:49 UTC) #2

Charlie Reis

Agreed that this doesn't fix the underlying bug (that some request IDs aren't being found), ...

5 years, 7 months ago (2015-05-19 23:33:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143913003/1

5 years, 7 months ago (2015-05-20 00:22:02 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 00:32:28 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/324a169646a722c4be1e222b3bb053c46a65956e
Cr-Commit-Position: refs/heads/master@{#330660}