Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Issue 1143903002: [Android] Refactor the native test wrappers. (RELAND) (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jbudorick+watch_chromium.org, jochen+watch_chromium.org, klundberg+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Refactor the native test wrappers. (RELAND) This is a reland of https://codereview.chromium.org/1126543009/, which broke gtests built by GN. BUG=476410 Committed: https://crrev.com/08b097a938942684558910dc9ca662c2a59ce3d2 Cr-Commit-Position: refs/heads/master@{#331056}

Patch Set 1 : original #

Patch Set 2 : fixed #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -499 lines) Patch
M build/android/pylib/constants/__init__.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +9 lines, -10 lines 0 comments Download
M build/android/pylib/gtest/local_device_gtest_run.py View 6 chunks +22 lines, -12 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 chunk +3 lines, -7 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +6 lines, -6 lines 0 comments Download
M build/android/pylib/utils/apk_helper.py View 2 chunks +57 lines, -16 lines 0 comments Download
A + build/apk_browsertest.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M build/config/android/rules.gni View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 2 chunks +1 line, -15 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 chunks +3 lines, -18 lines 0 comments Download
M components/test/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +4 lines, -0 lines 0 comments Download
D components/test/android/browsertests_apk/components_browser_tests_android.h View 1 chunk +0 lines, -16 lines 0 comments Download
D components/test/android/browsertests_apk/components_browser_tests_android.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M components/test/android/browsertests_apk/components_browser_tests_jni_onload.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java View 2 chunks +11 lines, -26 lines 0 comments Download
M content/content_shell.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 4 chunks +3 lines, -6 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +4 lines, -0 lines 0 comments Download
D content/shell/android/browsertests_apk/content_browser_tests_android.h View 1 chunk +0 lines, -16 lines 0 comments Download
D content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_jni_onload.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java View 2 chunks +11 lines, -26 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test.gyp View 2 chunks +36 lines, -20 lines 0 comments Download
M testing/android/native_test/BUILD.gn View 2 chunks +17 lines, -16 lines 0 comments Download
M testing/android/native_test/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
A testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java View 1 chunk +46 lines, -0 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 5 chunks +45 lines, -48 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java View 1 2 3 chunks +13 lines, -7 lines 0 comments Download
A testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java View 1 chunk +48 lines, -0 lines 0 comments Download
M testing/android/native_test/native_test_jni_onload.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/android/native_test/native_test_launcher.h View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M testing/android/native_test/native_test_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/android/native_test/native_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
jbudorick
PS1 is what landed in https://codereview.chromium.org/1126543009/ PS2 is the fixed version verified locally that tests ...
5 years, 7 months ago (2015-05-19 22:30:42 UTC) #2
cjhopman
lgtm
5 years, 7 months ago (2015-05-20 01:30:20 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-21 07:45:39 UTC) #4
Ted C
On 2015/05/21 07:45:39, jochen wrote: > lgtm lgtm
5 years, 7 months ago (2015-05-21 22:30:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143903002/20001
5 years, 7 months ago (2015-05-21 22:42:54 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/27419) ios_rel_device_ninja on ...
5 years, 7 months ago (2015-05-21 22:48:00 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143903002/40001
5 years, 7 months ago (2015-05-22 01:26:43 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-22 02:48:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143903002/40001
5 years, 7 months ago (2015-05-22 02:50:05 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-22 02:55:10 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 02:56:03 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/08b097a938942684558910dc9ca662c2a59ce3d2
Cr-Commit-Position: refs/heads/master@{#331056}

Powered by Google App Engine
This is Rietveld 408576698