Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2451)

Unified Diff: base/threading/platform_thread_posix.cc

Issue 11438022: Add ability to retrieve a thread_name given a thread_id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Store a version number for the current name for fast comparisons. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/platform_thread_posix.cc
diff --git a/base/threading/platform_thread_posix.cc b/base/threading/platform_thread_posix.cc
index 444edc58a6268649115f2f1583bc7b56374d961d..93fda8d2f2add64c62c080020ffab82683e97004 100644
--- a/base/threading/platform_thread_posix.cc
+++ b/base/threading/platform_thread_posix.cc
@@ -11,7 +11,7 @@
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/safe_strerror_posix.h"
-#include "base/threading/thread_local.h"
+#include "base/threading/thread_id_name_manager.h"
#include "base/threading/thread_restrictions.h"
#include "base/tracked_objects.h"
@@ -45,12 +45,6 @@ void InitThreading();
namespace {
-#if !defined(OS_MACOSX)
-// Mac name code is in in platform_thread_mac.mm.
-LazyInstance<ThreadLocalPointer<char> >::Leaky
- current_thread_name = LAZY_INSTANCE_INITIALIZER;
-#endif
-
struct ThreadParams {
PlatformThread::Delegate* delegate;
bool joinable;
@@ -195,9 +189,7 @@ void PlatformThread::Sleep(TimeDelta duration) {
#if defined(OS_LINUX)
// static
void PlatformThread::SetName(const char* name) {
- // have to cast away const because ThreadLocalPointer does not support const
- // void*
- current_thread_name.Pointer()->Set(const_cast<char*>(name));
+ ThreadIdNameManager::GetInstance()->SetNameForId(CurrentId(), name);
tracked_objects::ThreadData::InitializeThreadContext(name);
// On linux we can get the thread names to show up in the debugger by setting
@@ -222,9 +214,7 @@ void PlatformThread::SetName(const char* name) {
#else
// static
void PlatformThread::SetName(const char* name) {
- // have to cast away const because ThreadLocalPointer does not support const
- // void*
- current_thread_name.Pointer()->Set(const_cast<char*>(name));
+ ThreadIdNameManager::GetInstance()->SetNameForId(CurrentId(), name);
tracked_objects::ThreadData::InitializeThreadContext(name);
// (This should be relatively simple to implement for the BSDs; I
@@ -232,14 +222,15 @@ void PlatformThread::SetName(const char* name) {
}
#endif // defined(OS_LINUX)
-
-#if !defined(OS_MACOSX)
-// Mac is implemented in platform_thread_mac.mm.
// static
const char* PlatformThread::GetName() {
- return current_thread_name.Pointer()->Get();
+ return ThreadIdNameManager::GetInstance()->GetNameForId(CurrentId());
+}
+
+// static
+uint32 PlatformThread::GetVersionForName() {
+ return ThreadIdNameManager::GetInstance()->GetVersionForId(CurrentId());
}
-#endif
// static
bool PlatformThread::Create(size_t stack_size, Delegate* delegate,

Powered by Google App Engine
This is Rietveld 408576698