Add ability to retrieve a thread_name given a thread_id.

base/threading/platform_thread_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/platform_thread.h"
 
 #import <Foundation/Foundation.h>
 #include <dlfcn.h>
 #include <mach/mach.h>
 #include <mach/mach_time.h>
 #include <mach/thread_policy.h>
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
+#include "base/threading/thread_id_name_manager.h"
 #include "base/threading/thread_local.h"
 #include "base/tracked_objects.h"
 
 namespace base {
 
 namespace {
 
 LazyInstance<ThreadLocalPointer<char> >::Leaky
     current_thread_name = LAZY_INSTANCE_INITIALIZER;

[jonathan.backer, 2012/12/06 16:29:08]

Why the duplicated state? Now we have TLS for the pointer, but also in the
std::map.

[dsinclair, 2012/12/06 17:55:05]

Done.

Removed the thread locals from each of the files. Was able to remove the mac
specific PlatformThread::GetName as it becomes equivalent to the posix
implementation.

 
 }  // namespace
 
 // If Cocoa is to be used on more than one thread, it must know that the
 // application is multithreaded.  Since it's possible to enter Cocoa code
 // from threads created by pthread_thread_create, Cocoa won't necessarily
 // be aware that the application is multithreaded.  Spawning an NSThread is
 // enough to get Cocoa to set up for multithreaded operation, so this is done
 // if necessary before pthread_thread_create spawns any threads.
 //
 // http://developer.apple.com/documentation/Cocoa/Conceptual/Multithreading/CreatingThreads/chapter_4_section_4.html
 void InitThreading() {
   static BOOL multithreaded = [NSThread isMultiThreaded];
   if (!multithreaded) {
     // +[NSObject class] is idempotent.
     [NSThread detachNewThreadSelector:@selector(class)
                              toTarget:[NSObject class]
                            withObject:nil];
     multithreaded = YES;
 
     DCHECK([NSThread isMultiThreaded]);
   }
 }
 
 // static
 void PlatformThread::SetName(const char* name) {
   current_thread_name.Pointer()->Set(const_cast<char*>(name));
   tracked_objects::ThreadData::InitializeThreadContext(name);
 
+  ThreadIdNameManager::GetInstance()->SetNameForId(CurrentId(), name);
+
   // pthread_setname_np is only available in 10.6 or later, so test
   // for it at runtime.
   int (*dynamic_pthread_setname_np)(const char*);
   *reinterpret_cast<void**>(&dynamic_pthread_setname_np) =
       dlsym(RTLD_DEFAULT, "pthread_setname_np");
   if (!dynamic_pthread_setname_np)
     return;
 
   // Mac OS X does not expose the length limit of the name, so
   // hardcode it.
@@ skipping 118 matching lines @@
     case kThreadPriority_Normal:
       SetPriorityNormal(mach_thread_id);
       break;
     case kThreadPriority_RealtimeAudio:
       SetPriorityRealtimeAudio(mach_thread_id);
       break;
   }
 }
 
 }  // namespace base