Ignore integer to void* casts warnings in third_party/nss

Ignore integer to void* casts warnings.

[Cătălin Badea, 2012-12-05 09:01:23]

Please review.

[Cătălin Badea, 2012-12-05 09:25:26]

Build error being fixed by this patch:

/Users/catalin/projects/chromium/src/third_party/nss/mozilla/security/nss/lib/certhigh/certvfy.c:1219:6:
error: cast to 'void *' from smaller integer type 'unsigned int'
[-Werror,-Wint-to-pointer-cast]
            LOG_ERROR(log, cert, 0, flags);

[Mark Mentovai, 2012-12-05 13:27:17]

Wan-Teh, is this change correct for NSS?

[wtc, 2012-12-06 00:10:07]

badea: could you try this NSS patch? ('PRWord' is a type equivalent to
intptr_t.) Thanks.

Index: third_party/nss/mozilla/security/nss/lib/certhigh/certvfy.c
===================================================================
--- third_party/nss/mozilla/security/nss/lib/certhigh/certvfy.c	(revision
171358)
+++ third_party/nss/mozilla/security/nss/lib/certhigh/certvfy.c	(working copy)
@@ -333,14 +333,14 @@
 
 #define LOG_ERROR_OR_EXIT(log,cert,depth,arg) \
     if ( log != NULL ) { \
-	cert_AddToVerifyLog(log, cert, PORT_GetError(), depth, (void *)arg); \
+	cert_AddToVerifyLog(log, cert, PORT_GetError(), depth, (void *)(PRWord)arg); \
     } else { \
 	goto loser; \
     }
 
 #define LOG_ERROR(log,cert,depth,arg) \
     if ( log != NULL ) { \
-	cert_AddToVerifyLog(log, cert, PORT_GetError(), depth, (void *)arg); \
+	cert_AddToVerifyLog(log, cert, PORT_GetError(), depth, (void *)(PRWord)arg); \
     }
 
 static SECStatus

[wtc, 2012-12-06 00:49:59]

I verified that patch fixed the compiler warning. I filed an
upstream NSS bug report and attached a polished version of the
patch: https://bugzilla.mozilla.org/show_bug.cgi?id=818741

I can take care of patching Chromium's third_party/nss.

[Cătălin Badea, 2012-12-06 11:56:06]

On 2012/12/06 00:49:59, wtc wrote:
> I verified that patch fixed the compiler warning. I filed an
> upstream NSS bug report and attached a polished version of the
> patch: https://bugzilla.mozilla.org/show_bug.cgi?id=818741
> 
> I can take care of patching Chromium's third_party/nss.

Great. Thank you.