NTP5: Refactoring appData to use Tile's data implementation.

chrome/browser/resources/ntp_search/new_tab.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page. NewTabView manages page list,
  * dot list and handles apps pages callbacks from backend. It also handles
  * the layout of the Bottom Panel and the global UI states of the New Tab Page.
  */
@@ skipping 348 matching lines @@
       page.navigationDot = newDot;
       this.dotList.insertBefore(newDot,
                                 opt_refNode ? opt_refNode.navigationDot : null);
       // Set a tab index on the first dot.
       if (this.dotList.dots.length == 1)
         newDot.tabIndex = 3;
     },
 
     /**
      * Called by chrome when an app has changed positions.
-     * @param {Object} appData The data for the app. This contains page and
+     * @param {Object} data The data for the app. This contains page and
      *     position indices.
      */
-    appMoved: function(appData) {
+    appMoved: function(data) {
       assert(loadTimeData.getBoolean('showApps'));
 
-      var app = $(appData.id);
+      var app = $(data.id);
       assert(app, 'trying to move an app that doesn\'t exist');
       app.remove(false);
 
-      this.appsPage.insertApp(appData, false);
+      this.appsPage.insertApp(data, false);
     },
 
     /**
      * Called by chrome when an existing app has been disabled or
      * removed/uninstalled from chrome.
-     * @param {Object} appData A data structure full of relevant information for
+     * @param {Object} data A data structure full of relevant information for
      *     the app.
      * @param {boolean} isUninstall True if the app is being uninstalled;
      *     false if the app is being disabled.
      * @param {boolean} fromPage True if the removal was from the current page.
      */
-    appRemoved: function(appData, isUninstall, fromPage) {
+    appRemoved: function(data, isUninstall, fromPage) {
       assert(loadTimeData.getBoolean('showApps'));
 
-      var app = $(appData.id);
+      var app = $(data.id);
       assert(app, 'trying to remove an app that doesn\'t exist');
 
       if (!isUninstall)
-        app.replaceAppData(appData);
+        app.replaceAppData(data);
       else
         app.remove(!!fromPage);
     },
 
     /**
      * @return {boolean} If the page is still starting up.
      * @private
      */
     isStartingUp_: function() {
       return document.documentElement.classList.contains('starting-up');
@@ skipping 68 matching lines @@
 
       if (!this.appsLoaded_) {
         this.appsLoaded_ = true;
         cr.dispatchSimpleEvent(document, 'sectionready', true, true);
       }
     },
 
     /**
      * Called by chrome when a new app has been added to chrome or has been
      * enabled if previously disabled.
-     * @param {Object} appData A data structure full of relevant information for
+     * @param {Object} data A data structure full of relevant information for
      *     the app.
      * @param {boolean=} opt_highlight Whether the app about to be added should
      *     be highlighted.
      */
-    appAdded: function(appData, opt_highlight) {
+    appAdded: function(data, opt_highlight) {
       assert(loadTimeData.getBoolean('showApps'));
 
-      if (appData.id == this.highlightAppId) {
+      if (data.id == this.highlightAppId) {
         opt_highlight = true;
         this.highlightAppId = null;
       }
 
-      var pageIndex = appData.page_index || 0;
+      var pageIndex = data.page_index || 0;
 
-      var app = $(appData.id);
+      var app = $(data.id);
       if (app) {
-        app.replaceAppData(appData);
+        app.replaceAppData(data);
       } else if (opt_highlight) {
-        this.appsPage.insertAndHighlightApp(appData);
+        this.appsPage.insertAndHighlightApp(data);
         this.setShownPage_(loadTimeData.getInteger('apps_page_id'),
-                           appData.page_index);
+                           data.page_index);
       } else {
-        this.appsPage.insertApp(appData, false);
+        this.appsPage.insertApp(data, false);
       }
     },
 
     /**
      * Callback invoked by chrome whenever an app preference changes.
      * @param {Object} data An object with all the data on available
      *     applications.
      */
     appsPrefChangedCallback: function(data) {
       assert(loadTimeData.getBoolean('showApps'));
 
       for (var i = 0; i < data.apps.length; ++i) {
-        $(data.apps[i].id).appData = data.apps[i];
+        $(data.apps[i].id).data = data.apps[i];
       }
     },
 
     /**
      * Invoked whenever the pages in page-list have changed so that the
      * CardSlider knows about the new elements.
      */
     updateSliderCards: function() {
       var pageNo = Math.max(0, Math.min(this.cardSlider.currentCard,
                                         this.tilePages.length - 1));
@@ skipping 127 matching lines @@
     },
 
     /**
      * Listener for offline status change events. Updates apps that are
      * not offline-enabled to be grayscale if the browser is offline.
      * @private
      */
     updateOfflineEnabledApps_: function() {
       var apps = document.querySelectorAll('.app');
       for (var i = 0; i < apps.length; ++i) {
-        if (apps[i].appData.enabled && !apps[i].appData.offline_enabled) {
+        if (apps[i].data.enabled && !apps[i].data.offline_enabled) {
           apps[i].setIcon();
           apps[i].loadIcon();
         }
       }
     },
 
     /**
      * Returns the index of a given tile page.
      * @param {TilePage} page The TilePage we wish to find.
      * @return {number} The index of |page| or -1 if it is not in the
@@ skipping 474 matching lines @@
     setMostVisitedPages: setMostVisitedPages,
     setRecentlyClosedTabs: setRecentlyClosedTabs,
     showNotification: showNotification,
     themeChanged: themeChanged,
   };
 });
 
 document.addEventListener('DOMContentLoaded', ntp.onLoad);
 
 var toCssPx = cr.ui.toCssPx;