NTP5: Refactoring appData to use Tile's data implementation.

chrome/browser/resources/ntp_search/thumbnail_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp', function() {
   'use strict';
 
   var Tile = ntp.Tile;
   var TilePage = ntp.TilePage;
 
@@ skipping 38 matching lines @@
 
       this.tabIndex = -1;
       this.data_ = null;
       this.title = '';
     },
 
     /**
      * Update the appearance of this tile according to |data|.
      * @param {Object} data A dictionary of relevant data for the page.
      */
-    setData: function(data) {
-      Tile.prototype.setData.apply(this, arguments);
+    set data(data) {
+      Object.getOwnPropertyDescriptor(Tile.prototype, 'data').set.apply(this,
+          arguments);
 
       this.formatThumbnail_(data);
     },

[Dan Beam, 2012/12/05 18:34:05]

I'm not totally sure, but you might need a `get data` as well - as long as it
works for you...

[pedro (no code reviews), 2012/12/05 19:41:34]

Thumbnail page is basically a virtual class, and will never be instantiated,
that's why I did not include the getter here. The subclass (MostVisisted) has
the getter though.

 
     /**
      * Formats this tile according to |data|.
      * @param {Object} data A dictionary of relevant data for the page.
      * @private
      */
     formatThumbnail_: function(data) {
       var title = this.querySelector('.title');
       title.textContent = data.title;
       title.dir = data.direction;
@@ skipping 97 matching lines @@
     shouldAcceptDrag: function(e) {
       return false;
     },
   };
 
   return {
     Thumbnail: Thumbnail,
     ThumbnailPage: ThumbnailPage,
   };
 });