components/html_viewer/html_viewer.cc - Issue 1143793003: Remove application-specific args from Mandoline's shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/html_viewer.cc

Issue 1143793003: Remove application-specific args from Mandoline's shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/html_viewer/html_viewer.cc

diff --git a/components/html_viewer/html_viewer.cc b/components/html_viewer/html_viewer.cc

index 6198e09d6a523d46dab776f4b47b8af266a9e246..39067d5537b27b892a073d09fe9b424a3f11b94b 100644

--- a/components/html_viewer/html_viewer.cc

+++ b/components/html_viewer/html_viewer.cc

@@ -51,7 +51,6 @@ class HTMLViewerApplication : public mojo::Application {

setup_(setup) {}

void Initialize(ShellPtr shell,

- Array<String> args,

const String& url) override {

msw 2015/05/19 17:45:26 nit: fits on line above.

jam 2015/05/19 20:56:36 Done.

ServiceProviderPtr service_provider;

shell_ = shell.Pass();

« no previous file with comments | « no previous file | mojo/application/application_test_base_chromium.cc » ('j') | mojo/application/application_test_base_chromium.cc » ('J')