Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1143783003: Add the streamListen and streamCancel rpcs to the vm service. (Closed)

Created:
5 years, 7 months ago by turnidge
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the streamListen and streamCancel rpcs to the vm service. We currently support 5 streams: Isolate, Debug, GC, _Echo, and _Graph. Only generate events when at least one client is listening to the corresponding event stream. Only send events to the clients that actually request them. Implement this all as Dart streams in the service lib. Update tests. Fix a race in async_generator_..._test that was biting me. Committed: https://github.com/dart-lang/sdk/commit/0967b6307399b9296faa58b9b56eca045c9112d9

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Cleanups pre-review #

Total comments: 1

Patch Set 4 : before commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -161 lines) Patch
M runtime/bin/main.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/server.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +14 lines, -13 lines 0 comments Download
M runtime/observatory/lib/service_common.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 4 chunks +7 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 2 chunks +52 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/async_generator_breakpoint_test.dart View 1 3 chunks +23 lines, -18 lines 0 comments Download
M runtime/observatory/tests/service/code_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/coverage_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugger_inspect_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 1 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/echo_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/evaluate_activation_test.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/gc_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/graph_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/isolate_lifecycle_test.dart View 1 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/source_location_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/steal_breakpoint_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 4 chunks +29 lines, -5 lines 0 comments Download
M runtime/vm/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +14 lines, -10 lines 0 comments Download
M runtime/vm/json_stream.h View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/vm/service.h View 1 2 chunks +21 lines, -5 lines 0 comments Download
M runtime/vm/service.cc View 1 2 11 chunks +84 lines, -22 lines 0 comments Download
M runtime/vm/service/client.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service/message.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 1 2 9 chunks +117 lines, -26 lines 0 comments Download
M runtime/vm/service_event.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/service_event.cc View 1 2 chunks +31 lines, -0 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 7 months ago (2015-05-21 21:11:41 UTC) #2
Cutch
LGTMwC https://codereview.chromium.org/1143783003/diff/40001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/1143783003/diff/40001/runtime/vm/service.cc#newcode110 runtime/vm/service.cc:110: if (strcmp(stream_id, "Isolate") == 0) { would be ...
5 years, 7 months ago (2015-05-26 20:37:42 UTC) #3
turnidge
Committed patchset #4 (id:60001) manually as 0967b6307399b9296faa58b9b56eca045c9112d9 (presubmit successful).
5 years, 7 months ago (2015-05-26 20:52:40 UTC) #4
turnidge
5 years, 6 months ago (2015-06-04 06:30:39 UTC) #5
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698