Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1143773002: Add HTTP/2 RFC link in comment. (Closed)

Created:
5 years, 7 months ago by Bence
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HTTP/2 RFC link in comment. BUG=345769 Committed: https://crrev.com/2a4215cc1afd4cd1e0c019e356b69d900069784b Cr-Commit-Position: refs/heads/master@{#330367}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/socket/next_proto.h View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 7 months ago (2015-05-18 14:23:26 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/1143773002/diff/1/net/socket/next_proto.h File net/socket/next_proto.h (right): https://codereview.chromium.org/1143773002/diff/1/net/socket/next_proto.h#newcode36 net/socket/next_proto.h:36: kProtoSPDY4 = 107, // HTTP/2, see https://tools.ietf.org/html/rfc7540. I'm ...
5 years, 7 months ago (2015-05-18 14:30:59 UTC) #3
Bence
Thanks. https://codereview.chromium.org/1143773002/diff/1/net/socket/next_proto.h File net/socket/next_proto.h (right): https://codereview.chromium.org/1143773002/diff/1/net/socket/next_proto.h#newcode36 net/socket/next_proto.h:36: kProtoSPDY4 = 107, // HTTP/2, see https://tools.ietf.org/html/rfc7540. On ...
5 years, 7 months ago (2015-05-18 14:35:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143773002/1
5 years, 7 months ago (2015-05-18 14:36:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 15:41:39 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 15:42:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a4215cc1afd4cd1e0c019e356b69d900069784b
Cr-Commit-Position: refs/heads/master@{#330367}

Powered by Google App Engine
This is Rietveld 408576698