Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1924)

Unified Diff: chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc

Issue 1143723003: Update TabCapturePerformanceTest to more accurately time captures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/capture/content_video_capture_device_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc
diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc b/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc
index a86e94ebfeb0c5a78e7a8692144ef4631259c6b5..b7fa51e31a3ab41533b0b9759288d0698215fd0f 100644
--- a/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc
+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc
@@ -202,12 +202,13 @@ class TabCapturePerformanceTest
"ms");
EXPECT_TRUE(gpu_frames);
- // This prints out the average time between capture events.
- // As the capture frame rate is capped at 30fps, this score
- // cannot get any better than (lower) 33.33 ms.
+ // This prints out the average time between capture events. As the capture
+ // frame rate is capped at 30fps, this score cannot get any better than
+ // (lower) 33.33 ms. Note that we track the CaptureSucceeded event rather
+ // than Capture, as Capture only indicates that a capture was requested.
EXPECT_TRUE(PrintResults(analyzer.get(),
test_name,
- "Capture",
+ "CaptureSucceeded",
hubbe 2015/05/19 19:14:52 How about printing out both results? (Add a TODO t
ericrk 2015/05/19 20:02:08 Good call - done.
"ms"));
}
};
« no previous file with comments | « no previous file | content/browser/media/capture/content_video_capture_device_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698