Update TabCapturePerformanceTest to more accurately time captures.

Update TabCapturePerformanceTest to more accurately time captures.

Currently TabCapturePerformanceTest records the time between "Capture"
events to determine the rate of capture. These events are issued whenever
a capture is requested, even if it is later aborted, and doesn't represent
the actual capture framerate. This CL adds an event on capture
success which will provide a more accurate idea of capture framerate.

BUG=489796
Committed: https://crrev.com/5a1526c383a97e2dd3998af7432fa3d9500a510c
Cr-Commit-Position: refs/heads/master@{#330785}

[ericrk, 2015-05-19 18:49:43]

ericrk@chromium.org changed reviewers:
+ hubbe@chromium.org

[ericrk, 2015-05-19 18:51:00]

ericrk@chromium.org changed reviewers:
+ miu@chromium.org

[ericrk, 2015-05-19 18:54:32]

Hi Hubbe, Miu,

I'm making an update to the TabCapturePerformance to better measure Capture
framerate. This change makes it easier to diagnose issues such as 481656, as we
now use the time between successful captures as opposed to requests for capture
(which may be aborted).

Let me know how this looks. Thanks

[hubbe, 2015-05-19 19:14:52]

https://codereview.chromium.org/1143723003/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc
(right):

https://codereview.chromium.org/1143723003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:211:
"CaptureSucceeded",
How about printing out both results?
(Add a TODO to remove the "Capture" one in the future.)

[ericrk, 2015-05-19 20:00:57]

Patchset #2 (id:20001) has been deleted

[ericrk, 2015-05-19 20:02:09]

https://codereview.chromium.org/1143723003/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc
(right):

https://codereview.chromium.org/1143723003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:211:
"CaptureSucceeded",
On 2015/05/19 19:14:52, hubbe wrote:
> How about printing out both results?
> (Add a TODO to remove the "Capture" one in the future.)

Good call - done.

[hubbe, 2015-05-19 20:30:04]

lgtm

[ericrk, 2015-05-19 20:32:24]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2015-05-19 20:33:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143723003/40001

[commit-bot: I haz the power, 2015-05-19 20:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 20:41:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[miu, 2015-05-20 03:34:48]

The CQ bit was checked by miu@chromium.org

[miu, 2015-05-20 03:34:49]

lgtm

[commit-bot: I haz the power, 2015-05-20 03:35:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143723003/40001

[commit-bot: I haz the power, 2015-05-20 03:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 03:42:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ericrk, 2015-05-20 17:48:12]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2015-05-20 17:48:13]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org,
miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1143723003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-20 17:49:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143723003/60001

[commit-bot: I haz the power, 2015-05-20 19:46:11]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-05-20 19:47:01]

Patchset 3 (id:??) landed as
https://crrev.com/5a1526c383a97e2dd3998af7432fa3d9500a510c
Cr-Commit-Position: refs/heads/master@{#330785}