Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11437038: Revert 171408 (Closed)

Created:
8 years ago by raymes
Modified:
8 years ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, piman+watch_chromium.org, native-client-reviews_googlegroups.com, ihf+watch_chromium.org
Visibility:
Public.

Description

Revert 171408 > The refactors PPB_Flash_File_ModuleLocal/FileRef to the new resource model. Calls for both these interfaces are now made directly to the browser. This removes the in-process implementation for these interfaces also (as they are flash-only). Tests are added for PPB_Flash_File_ModuleLocal. > > Review URL: https://codereview.chromium.org/11359097 TBR=raymes@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171562

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1676 lines, -1270 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/nacl/nacl_ipc_adapter.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.h View 4 chunks +1 line, -12 lines 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc View 4 chunks +4 lines, -29 lines 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_test.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc View 2 chunks +0 lines, -4 lines 0 comments Download
A content/browser/renderer_host/pepper/pepper_file_message_filter.h View 1 chunk +138 lines, -0 lines 0 comments Download
A content/browser/renderer_host/pepper/pepper_file_message_filter.cc View 1 chunk +367 lines, -0 lines 0 comments Download
D content/browser/renderer_host/pepper/pepper_flash_file_host.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/browser/renderer_host/pepper/pepper_flash_file_host.cc View 1 chunk +0 lines, -365 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/common/all_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/pepper_plugin_registry.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_ppapi_host.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 chunk +20 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 2 chunks +81 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_flash_file.h View 1 chunk +11 lines, -2 lines 0 comments Download
M ppapi/cpp/private/flash_file.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ppapi/cpp/private/flash_file.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M ppapi/ppapi_ipc.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
D ppapi/proxy/flash_file_resource.h View 1 chunk +0 lines, -73 lines 0 comments Download
D ppapi/proxy/flash_file_resource.cc View 1 chunk +0 lines, -231 lines 0 comments Download
A ppapi/proxy/pepper_file_messages.h View 1 chunk +82 lines, -0 lines 0 comments Download
A ppapi/proxy/pepper_file_messages.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_resource.h View 7 chunks +10 lines, -17 lines 0 comments Download
M ppapi/proxy/plugin_resource.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 4 chunks +11 lines, -30 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 3 chunks +0 lines, -44 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.h View 5 chunks +41 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 5 chunks +234 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M ppapi/proxy/resource_message_params.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/resource_message_params.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ppapi/proxy/serialized_structs.h View 6 chunks +3 lines, -14 lines 0 comments Download
M ppapi/proxy/serialized_structs.cc View 3 chunks +4 lines, -13 lines 0 comments Download
M ppapi/shared_impl/file_path.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ppapi/shared_impl/file_path.cc View 2 chunks +31 lines, -0 lines 0 comments Download
A ppapi/shared_impl/ppb_flash_shared.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ppapi/shared_impl/ppb_flash_shared.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M ppapi/shared_impl/resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/singleton_resource_id.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/test_flash_file.h View 1 chunk +2 lines, -13 lines 0 comments Download
M ppapi/tests/test_flash_file.cc View 3 chunks +3 lines, -209 lines 0 comments Download
M ppapi/thunk/ppb_file_ref_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/ppb_flash_api.h View 1 chunk +34 lines, -0 lines 0 comments Download
D ppapi/thunk/ppb_flash_file_api.h View 1 chunk +0 lines, -63 lines 0 comments Download
M ppapi/thunk/ppb_flash_file_fileref_thunk.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_flash_file_modulelocal_thunk.cc View 2 chunks +31 lines, -18 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +20 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 chunk +21 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.h View 2 chunks +30 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.cc View 3 chunks +229 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/11437038/5001
8 years ago (2012-12-06 17:13:50 UTC) #1
commit-bot: I haz the power
8 years ago (2012-12-06 17:14:55 UTC) #2 
Presubmit check for 11437038-5001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
Your #include order seems to be broken. Send mail to
marja@chromium.org if this is not the case.
      ppapi/proxy/pepper_file_messages.cc:15 \
      ppapi/proxy/pepper_file_messages.cc:19 \
      ppapi/proxy/pepper_file_messages.cc:25 \
      ppapi/proxy/pepper_file_messages.cc:31

Missing PPAPI IDL for private interface, please generate IDL:

***************
  ppapi/c/private/ppb_flash_file.h
***************

Presubmit checks took 5.8s to calculate.

Powered by Google App Engine
This is Rietveld 408576698