Added Uint8ClampedList. COmpielr optimziations to follow in next CL.

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/token.h"
@@ skipping 45 matching lines @@
         V(Mint)                                                                \
         V(Bigint)                                                              \
       V(Double)                                                                \
     V(Bool)                                                                    \
     V(Array)                                                                   \
       V(ImmutableArray)                                                        \
     V(GrowableObjectArray)                                                     \
     V(ByteArray)                                                               \
       V(Int8Array)                                                             \
       V(Uint8Array)                                                            \
+      V(Uint8ClampedArray)                                                     \
       V(Int16Array)                                                            \
       V(Uint16Array)                                                           \
       V(Int32Array)                                                            \
       V(Uint32Array)                                                           \
       V(Int64Array)                                                            \
       V(Uint64Array)                                                           \
       V(Float32Array)                                                          \
       V(Float64Array)                                                          \
       V(ExternalInt8Array)                                                     \
       V(ExternalUint8Array)                                                    \
+      V(ExternalUint8ClampedArray)                                             \
       V(ExternalInt16Array)                                                    \
       V(ExternalUint16Array)                                                   \
       V(ExternalInt32Array)                                                    \
       V(ExternalUint32Array)                                                   \
       V(ExternalInt64Array)                                                    \
       V(ExternalUint64Array)                                                   \
       V(ExternalFloat32Array)                                                  \
       V(ExternalFloat64Array)                                                  \
     V(Stacktrace)                                                              \
     V(JSRegExp)                                                                \
@@ skipping 1181 matching lines @@
 
 
 class RawUint8Array : public RawByteArray {
   RAW_HEAP_OBJECT_IMPLEMENTATION(Uint8Array);
 
   // Variable length data follows here.
   uint8_t data_[0];
 };
 
 
+class RawUint8ClampedArray : public RawByteArray {

[siva, 2012/12/06 01:31:13]

I would make this a subclass of RawUint8Array
and not have the data_ field here.

[srdjan, 2012/12/06 19:23:14]

Done.

+  RAW_HEAP_OBJECT_IMPLEMENTATION(Uint8ClampedArray);
+
+  // Variable length data follows here.
+  uint8_t data_[0];
+};
+
+
 class RawInt16Array : public RawByteArray {
   RAW_HEAP_OBJECT_IMPLEMENTATION(Int16Array);
 
   // Variable length data follows here.
   int16_t data_[0];
 };
 
 
 class RawUint16Array : public RawByteArray {
   RAW_HEAP_OBJECT_IMPLEMENTATION(Uint16Array);
@@ skipping 97 matching lines @@
 class RawExternalUint8Array : public RawByteArray {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalUint8Array);
 
   ExternalByteArrayData<uint8_t>* external_data_;
 
   friend class TokenStream;
   friend class RawTokenStream;
 };
 
 
+class RawExternalUint8ClampedArray : public RawByteArray {

[siva, 2012/12/06 01:31:13]

Ditto.

[srdjan, 2012/12/06 19:23:14]

Done.

+  RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalUint8ClampedArray);
+
+  ExternalByteArrayData<uint8_t>* external_data_;
+
+  friend class TokenStream;
+  friend class RawTokenStream;

[siva, 2012/12/06 01:31:13]

Why are these friend class stuff needed here?

[srdjan, 2012/12/06 19:23:14]

Removed.

+};
+
+
 class RawExternalInt16Array : public RawByteArray {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalInt16Array);
 
   ExternalByteArrayData<int16_t>* external_data_;
 };
 
 
 class RawExternalUint16Array : public RawByteArray {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalUint16Array);
 
@@ skipping 193 matching lines @@
          kByteArrayCid == kArrayCid + 3);
   return (index >= kArrayCid && index < kByteArrayCid) ||
       IsByteArrayClassId(index);
 }
 
 
 inline bool RawObject::IsByteArrayClassId(intptr_t index) {
   // Make sure this function is updated when new ByteArray types are added.
   ASSERT(kInt8ArrayCid == kByteArrayCid + 1 &&
          kUint8ArrayCid == kByteArrayCid + 2 &&
-         kInt16ArrayCid == kByteArrayCid + 3 &&
-         kUint16ArrayCid == kByteArrayCid + 4 &&
-         kInt32ArrayCid == kByteArrayCid + 5 &&
-         kUint32ArrayCid == kByteArrayCid + 6 &&
-         kInt64ArrayCid == kByteArrayCid + 7 &&
-         kUint64ArrayCid == kByteArrayCid + 8 &&
-         kFloat32ArrayCid == kByteArrayCid + 9 &&
-         kFloat64ArrayCid == kByteArrayCid + 10 &&
-         kExternalInt8ArrayCid == kByteArrayCid + 11 &&
-         kExternalUint8ArrayCid == kByteArrayCid + 12 &&
-         kExternalInt16ArrayCid == kByteArrayCid + 13 &&
-         kExternalUint16ArrayCid == kByteArrayCid + 14 &&
-         kExternalInt32ArrayCid == kByteArrayCid + 15 &&
-         kExternalUint32ArrayCid == kByteArrayCid + 16 &&
-         kExternalInt64ArrayCid == kByteArrayCid + 17 &&
-         kExternalUint64ArrayCid == kByteArrayCid + 18 &&
-         kExternalFloat32ArrayCid == kByteArrayCid + 19 &&
-         kExternalFloat64ArrayCid == kByteArrayCid + 20 &&
-         kStacktraceCid == kByteArrayCid + 21);
+         kUint8ClampedArrayCid == kByteArrayCid + 3 &&
+         kInt16ArrayCid == kByteArrayCid + 4 &&
+         kUint16ArrayCid == kByteArrayCid + 5 &&
+         kInt32ArrayCid == kByteArrayCid + 6 &&
+         kUint32ArrayCid == kByteArrayCid + 7 &&
+         kInt64ArrayCid == kByteArrayCid + 8 &&
+         kUint64ArrayCid == kByteArrayCid + 9 &&
+         kFloat32ArrayCid == kByteArrayCid + 10 &&
+         kFloat64ArrayCid == kByteArrayCid + 11 &&
+         kExternalInt8ArrayCid == kByteArrayCid + 12 &&
+         kExternalUint8ArrayCid == kByteArrayCid + 13 &&
+         kExternalUint8ClampedArrayCid == kByteArrayCid + 14 &&
+         kExternalInt16ArrayCid == kByteArrayCid + 15 &&
+         kExternalUint16ArrayCid == kByteArrayCid + 16 &&
+         kExternalInt32ArrayCid == kByteArrayCid + 17 &&
+         kExternalUint32ArrayCid == kByteArrayCid + 18 &&
+         kExternalInt64ArrayCid == kByteArrayCid + 19 &&
+         kExternalUint64ArrayCid == kByteArrayCid + 20 &&
+         kExternalFloat32ArrayCid == kByteArrayCid + 21 &&
+         kExternalFloat64ArrayCid == kByteArrayCid + 22 &&
+         kStacktraceCid == kByteArrayCid + 23);
   return (index >= kByteArrayCid && index <= kExternalFloat64ArrayCid);
 }
 
 inline bool RawObject::IsExternalByteArrayClassId(intptr_t index) {
   // Make sure this function is updated when new ByteArray types are added.
   ASSERT(kExternalUint8ArrayCid == kExternalInt8ArrayCid + 1 &&
-         kExternalInt16ArrayCid == kExternalInt8ArrayCid + 2 &&
-         kExternalUint16ArrayCid == kExternalInt8ArrayCid + 3 &&
-         kExternalInt32ArrayCid == kExternalInt8ArrayCid + 4 &&
-         kExternalUint32ArrayCid == kExternalInt8ArrayCid + 5 &&
-         kExternalInt64ArrayCid == kExternalInt8ArrayCid + 6 &&
-         kExternalUint64ArrayCid == kExternalInt8ArrayCid + 7 &&
-         kExternalFloat32ArrayCid == kExternalInt8ArrayCid + 8 &&
-         kExternalFloat64ArrayCid == kExternalInt8ArrayCid + 9 &&
-         kStacktraceCid == kExternalInt8ArrayCid + 10);
+         kExternalUint8ClampedArrayCid == kExternalInt8ArrayCid + 2 &&
+         kExternalInt16ArrayCid == kExternalInt8ArrayCid + 3 &&
+         kExternalUint16ArrayCid == kExternalInt8ArrayCid + 4 &&
+         kExternalInt32ArrayCid == kExternalInt8ArrayCid + 5 &&
+         kExternalUint32ArrayCid == kExternalInt8ArrayCid + 6 &&
+         kExternalInt64ArrayCid == kExternalInt8ArrayCid + 7 &&
+         kExternalUint64ArrayCid == kExternalInt8ArrayCid + 8 &&
+         kExternalFloat32ArrayCid == kExternalInt8ArrayCid + 9 &&
+         kExternalFloat64ArrayCid == kExternalInt8ArrayCid + 10 &&
+         kStacktraceCid == kExternalInt8ArrayCid + 11);
   return (index >= kExternalInt8ArrayCid && index <= kExternalFloat64ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_