Add logging system to pub and sprinkle some logging in.

utils/pub/command_lish.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library command_lish;
 
 import 'dart:io';
 import 'dart:json';
 import 'dart:uri';
 
 import '../../pkg/args/lib/args.dart';
 import '../../pkg/http/lib/http.dart' as http;
+import 'git.dart' as git;
+import 'io.dart';
+import 'log.dart' as log;
+import 'oauth2.dart' as oauth2;
 import 'pub.dart';
-import 'io.dart';
-import 'git.dart' as git;
-import 'oauth2.dart' as oauth2;
 
 // TODO(nweiz): Make "publish" the primary name for this command. See issue
 // 6949.
 /// Handles the `lish` and `publish` pub commands.
 class LishCommand extends PubCommand {
   final description = "publish the current package to pub.dartlang.org";
   final usage = "pub publish [options]";
   final aliases = const ["lish", "lush"];
 
   ArgParser get commandParser {
@@ skipping 16 matching lines @@
       //   oauth2 package should throw an AuthorizationException in this case
       //   (contingent on issue 6813 and 6275). We should have the user
       //   re-authorize the client, then restart the command. We should also do
       //   this in case of an ExpirationException. See issue 6950.
       //
       // * Cloud Storage can provide an XML-formatted error. We should report
       //   that error and exit.
       return Futures.wait([
         client.get(server.resolve("/packages/versions/new.json")),
         _filesToPublish.transform((files) {
+          log.fine('Archiving and publishing:');
+          files.forEach(log.fine);

[nweiz, 2012/12/05 23:56:54]

Probably more readable if we indent these file names (see also _logToSdout).

It seems like createTarGz should have this logging.

[Bob Nystrom, 2012/12/06 01:33:26]

Done.

           return createTarGz(files, baseDir: entrypoint.root.dir);
         }).chain(consumeInputStream)
       ]).chain((results) {
         var response = results[0];
         var packageBytes = results[1];
         var parameters = _parseJson(response);
 
         var url = _expectField(parameters, 'url', response);
         if (url is! String) _invalidServerResponse(response);
         cloudStorageUrl = new Uri.fromString(url);
@@ skipping 14 matching lines @@
         var location = response.headers['location'];
         if (location == null) throw new PubHttpException(response);
         return location;
       }).chain((location) => client.get(location)).transform((response) {
         var parsed = _parseJson(response);
         if (parsed['success'] is! Map ||
             !parsed['success'].containsKey('message') ||
             parsed['success']['message'] is! String) {
           _invalidServerResponse(response);
         }
-        print(parsed['success']['message']);
+        log.message(parsed['success']['message']);
       });
     }).transformException((e) {
       if (e is PubHttpException) {
         var url = e.response.request.url;
         if (url.toString() == cloudStorageUrl.toString()) {
           // TODO(nweiz): the response may have XML-formatted information about
           // the error. Try to parse that out once we have an easily-accessible
           // XML parser.
           throw 'Failed to upload the package.';
         } else if (url.origin == server.origin) {
           var errorMap = _parseJson(e.response);
           if (errorMap['error'] is! Map ||
               !errorMap['error'].containsKey('message') ||
               errorMap['error']['message'] is! String) {
             _invalidServerResponse(e.response);
           }
           throw errorMap['error']['message'];
         }
       }
 
       if (e is! oauth2.ExpirationException) throw e;
 
-      printError("Pub's authorization to upload packages has expired and can't "
+      log.error("Pub's authorization to upload packages has expired and can't "
           "be automatically refreshed.");
       return onRun();
     });
   }
 
   /// The basenames of files that are automatically excluded from archives.
   final _BLACKLISTED_FILES = const ['pubspec.lock'];
 
   /// The basenames of directories that are automatically excluded from
   /// archives.
@@ skipping 47 matching lines @@
   _expectField(Map map, String key, http.Response response) {
     if (map.containsKey(key)) return map[key];
     _invalidServerResponse(response);
   }
 
   /// Throws an error describing an invalid response from the server.
   void _invalidServerResponse(http.Response response) {
     throw 'Invalid server response:\n${response.body}';
   }
 }