Issue 11437016: Use count-based profiling exclusively.

Issue 11437016: Use count-based profiling exclusively. (Closed)

Created:
8 years ago by Sven Panne

Modified:
8 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use count-based profiling exclusively. Committed: http://code.google.com/p/v8/source/detail?r=13158

Patch Set 2 : Rebased. Renamings. #

Total comments: 16

Patch Set 3 : Addressed review comments #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -481 lines)			Patch
M	src/arm/deoptimizer-arm.cc	View	1 2	3 chunks	+11 lines, -21 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1	2 chunks	+16 lines, -27 lines	0 comments	Download
M	src/execution.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/execution.cc	View		2 chunks	+3 lines, -26 lines	0 comments	Download
M	src/flag-definitions.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/full-codegen.h	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/full-codegen.cc	View	1	4 chunks	+5 lines, -6 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	1 2	3 chunks	+9 lines, -21 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	3 chunks	+16 lines, -30 lines	0 comments	Download
M	src/mips/deoptimizer-mips.cc	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1	2 chunks	+18 lines, -29 lines	0 comments	Download
M	src/platform-cygwin.cc	View		2 chunks	+3 lines, -19 lines	0 comments	Download
M	src/platform-freebsd.cc	View		3 chunks	+5 lines, -40 lines	0 comments	Download
M	src/platform-linux.cc	View		4 chunks	+7 lines, -45 lines	0 comments	Download
M	src/platform-macos.cc	View		2 chunks	+3 lines, -19 lines	0 comments	Download
M	src/platform-openbsd.cc	View		3 chunks	+7 lines, -45 lines	0 comments	Download
M	src/platform-solaris.cc	View		3 chunks	+7 lines, -46 lines	0 comments	Download
M	src/platform-win32.cc	View		2 chunks	+3 lines, -19 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/runtime-profiler.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/runtime-profiler.cc	View		2 chunks	+2 lines, -15 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1 2	3 chunks	+9 lines, -21 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	3 chunks	+16 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comments. https://codereview.chromium.org/11437016/diff/2001/src/arm/deoptimizer-arm.cc File src/arm/deoptimizer-arm.cc (right): https://codereview.chromium.org/11437016/diff/2001/src/arm/deoptimizer-arm.cc#newcode117 src/arm/deoptimizer-arm.cc:117: static const int32_t kBranchBeforeStackCheck = 0x2a000001; ...

8 years ago (2012-12-06 16:25:40 UTC) #2

Sven Panne

8 years ago (2012-12-07 08:54:56 UTC) #3

Landing...

https://codereview.chromium.org/11437016/diff/2001/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):

https://codereview.chromium.org/11437016/diff/2001/src/arm/deoptimizer-arm.cc...
src/arm/deoptimizer-arm.cc:117: static const int32_t kBranchBeforeStackCheck =
0x2a000001;
On 2012/12/06 16:25:41, Jakob wrote:
> not needed anymore, please remove.

Interesting... I thought that g++ would emit a warning for such cases. :-/ Done.

https://codereview.chromium.org/11437016/diff/2001/src/arm/deoptimizer-arm.cc...
src/arm/deoptimizer-arm.cc:127: //  e1 5d 00 0c       cmp sp, <limit>
On 2012/12/06 16:25:41, Jakob wrote:
> please update this comment

Done.

https://codereview.chromium.org/11437016/diff/2001/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):

https://codereview.chromium.org/11437016/diff/2001/src/ia32/deoptimizer-ia32....
src/ia32/deoptimizer-ia32.cc:213: static const byte kJaeInstruction = 0x73;
On 2012/12/06 16:25:41, Jakob wrote:
> not needed anymore, please remove.

Done.

https://codereview.chromium.org/11437016/diff/2001/src/ia32/deoptimizer-ia32....
src/ia32/deoptimizer-ia32.cc:214: static const byte kJaeOffset = 0x07;
On 2012/12/06 16:25:41, Jakob wrote:
> not needed anymore, please remove.

Done.

https://codereview.chromium.org/11437016/diff/2001/src/ia32/deoptimizer-ia32....
src/ia32/deoptimizer-ia32.cc:229: //     cmp esp, <limit>
On 2012/12/06 16:25:41, Jakob wrote:
> Please update this comment. Feel free to use pseudo instructions when the
> details don't matter.

Done.

https://codereview.chromium.org/11437016/diff/2001/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (right):

https://codereview.chromium.org/11437016/diff/2001/src/x64/deoptimizer-x64.cc...
src/x64/deoptimizer-x64.cc:119: static const byte kJaeInstruction = 0x73;
On 2012/12/06 16:25:41, Jakob wrote:
> not needed anymore, please remove.

Done.

https://codereview.chromium.org/11437016/diff/2001/src/x64/deoptimizer-x64.cc...
src/x64/deoptimizer-x64.cc:120: static const byte kJaeOffset = 0x07;
On 2012/12/06 16:25:41, Jakob wrote:
> not needed anymore, please remove.

Done.

https://codereview.chromium.org/11437016/diff/2001/src/x64/deoptimizer-x64.cc...
src/x64/deoptimizer-x64.cc:134: //     cmp rsp, <limit>
On 2012/12/06 16:25:41, Jakob wrote:
> please update this comment

Done.

Expand Messages | Collapse Messages