Issue 11437005: aura-x11: Select for non-touch events before selecting for touch events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11437005: aura-x11: Select for non-touch events before selecting for touch events. (Closed)

Created:
8 years ago by sadrul

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura-x11: Select for non-touch events before selecting for touch events. Selecting for touch-events seem to fail when loggin in incognito. This causes all XI2 events to fail. To avoid this, select for non-touch XI2 events first, and then select for touch events. So even if the latter select fails, the rest of the XI2 events will be received correctly. This fixes some key events in incognito (e.g. top-row keys etc.). BUG=163988 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171142

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -20 lines)			Patch
	M	ui/aura/root_window_host_linux.cc	View		1 chunk	+15 lines, -7 lines	0 comments	Download
	M	ui/base/touch/touch_factory.cc	View		1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

This is a slightly better fix from https://codereview.chromium.org/11316337/ Both are band-aids though. But this makes ...

8 years ago (2012-12-05 00:37:17 UTC) #1

Yusuke Sato

8 years ago (2012-12-05 01:04:21 UTC) #3

confirmed that the CL fixes the issue using Lumpy.

w/o this CL, Command button on an Apple USB keyboard works as Win-L in guest
mode.
with this CL, Command button on an Apple USB keyboard works as Control in guest
mode.

Expand Messages | Collapse Messages