Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1143663008: Merge to XFA: Remove FX_Alloc() null checks now that it can't return NULL. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Pick up segv fix from master before landing. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -453 lines) Patch
M core/include/fxge/fx_ge.h View 2 chunks +6 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 4 chunks +6 lines, -12 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 4 chunks +0 lines, -12 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 1 chunk +33 lines, -35 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 10 chunks +3 lines, -39 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jbig.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M core/src/fxcrt/extension.h View 2 chunks +1 line, -6 lines 0 comments Download
M core/src/fxcrt/fx_basic_array.cpp View 4 chunks +0 lines, -15 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M core/src/fxcrt/fx_basic_maps.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M core/src/fxcrt/fx_basic_plex.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxcrt/fxcrt_platforms.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxcrt/fxcrt_posix.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxcrt/xml_int.h View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/agg/agg23/agg_array.h View 1 chunk +1 line, -5 lines 0 comments Download
M core/src/fxge/agg/agg23/fx_agg_path_storage.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/agg/agg23/fx_agg_rasterizer_scanline_aa.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 9 chunks +0 lines, -37 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 4 chunks +3 lines, -12 lines 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 3 chunks +3 lines, -16 lines 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 1 9 chunks +19 lines, -43 lines 0 comments Download
M core/src/fxge/ge/fx_ge_ps.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dib.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 5 chunks +0 lines, -28 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 2 chunks +13 lines, -17 lines 0 comments Download
M third_party/base/numerics/safe_conversions_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
TBR
5 years, 7 months ago (2015-05-19 21:49:55 UTC) #1
Lei Zhang
lgtm Do you need to go through the XFA branch and find the branch specific ...
5 years, 7 months ago (2015-05-19 21:50:52 UTC) #2
Tom Sepez
On 2015/05/19 21:50:52, Lei Zhang wrote: > lgtm > > Do you need to go ...
5 years, 7 months ago (2015-05-19 21:51:27 UTC) #3
Tom Sepez
On 2015/05/19 21:51:27, Tom Sepez wrote: > On 2015/05/19 21:50:52, Lei Zhang wrote: > > ...
5 years, 7 months ago (2015-05-19 21:51:51 UTC) #4
Tom Sepez
5 years, 7 months ago (2015-05-20 16:50:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d50b172a9d3a05704748f0798b5aaa422485abbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698