core/src/fxcodec/codec/fx_codec_fax.cpp - Issue 1143663004: Add safe FX_Alloc2D() macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/codec/fx_codec_fax.cpp

Issue 1143663004: Add safe FX_Alloc2D() macro (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Drop one file, indent. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcodec/codec/fx_codec_fax.cpp

diff --git a/core/src/fxcodec/codec/fx_codec_fax.cpp b/core/src/fxcodec/codec/fx_codec_fax.cpp

index 667b713df82f3e7ee88943da02e001c4a162c210..33e89e4f92b52f9ff5219d42f5456b354ac924db 100644

--- a/core/src/fxcodec/codec/fx_codec_fax.cpp

+++ b/core/src/fxcodec/codec/fx_codec_fax.cpp

@@ -949,10 +949,7 @@ CCodec_FaxEncoder::CCodec_FaxEncoder(FX_LPCBYTE src_buf, int width, int height,

return;

}

FXSYS_memset8(m_pRefLine, 0xff, m_Pitch);

- m_pLineBuf = FX_Alloc(FX_BYTE, m_Pitch * 8);

- if (m_pLineBuf == NULL) {

- return;

- }

+ m_pLineBuf = FX_Alloc2D(FX_BYTE, m_Pitch, 8);

m_DestBuf.EstimateSize(0, 10240);

}

CCodec_FaxEncoder::~CCodec_FaxEncoder()

« no previous file with comments | « core/src/fpdftext/fpdf_text.cpp ('k') | core/src/fxcodec/codec/fx_codec_flate.cpp » ('j') | no next file with comments »