core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp - Issue 1143663004: Add safe FX_Alloc2D() macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

Issue 1143663004: Add safe FX_Alloc2D() macro (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Drop one file, indent. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

index ac3f2b29d73ce0a140854762cb0b0aa3872a12d1..6fa7419a419dfe78f90d9eaee9361502af962668 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp

@@ -296,7 +296,7 @@ void CPDF_DecryptFilter::v_FilterFinish(CFX_BinaryBuf& dest_buf)

extern "C" {

static void* my_alloc_func (void* opaque, unsigned int items, unsigned int size)

{

- return FX_Alloc(FX_BYTE, items * size);

+ return FX_Alloc2D(FX_BYTE, items, size);

}

static void my_free_func (void* opaque, void* address)

{