core/src/fxge/skia/fx_skia_device.cpp - Issue 1143663004: Add safe FX_Alloc2D() macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/skia/fx_skia_device.cpp

Issue 1143663004: Add safe FX_Alloc2D() macro (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/skia/fx_skia_device.cpp

diff --git a/core/src/fxge/skia/fx_skia_device.cpp b/core/src/fxge/skia/fx_skia_device.cpp

index cc4059dd1d447dce697480c35016a2fcd3da078a..a483eca5ca8f18dfec3cb4d61a60dd432f9190c2 100644

--- a/core/src/fxge/skia/fx_skia_device.cpp

+++ b/core/src/fxge/skia/fx_skia_device.cpp

@@ -210,7 +210,7 @@ static void SkRasterizeStroke(SkPaint& spaint, SkPath* dstPathData, SkPath& path

dstPathData->transform(smatrix);

} else {

int count = (pGraphState->m_DashCount+1)/2;

- SkScalar* intervals = FX_Alloc(SkScalar, count* sizeof (SkScalar));

+ SkScalar* intervals = FX_Alloc2D(SkScalar, count, sizeof(SkScalar));

// Set dash pattern

for (int i = 0; i < count; i ++) {

FX_FIXFLOAT on = pGraphState->m_DashArray[i*2];