core/src/fxcrt/fx_basic_plex.cpp - Issue 1143663004: Add safe FX_Alloc2D() macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_plex.cpp

Issue 1143663004: Add safe FX_Alloc2D() macro (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_basic_plex.cpp

diff --git a/core/src/fxcrt/fx_basic_plex.cpp b/core/src/fxcrt/fx_basic_plex.cpp

index bff55461f401fcce1a72e314d17fb11e80b85d99..78319bd5da15a76416c77093a54cfb96118b5c88 100644

--- a/core/src/fxcrt/fx_basic_plex.cpp

+++ b/core/src/fxcrt/fx_basic_plex.cpp

@@ -9,9 +9,6 @@

CFX_Plex* CFX_Plex::Create(CFX_Plex*& pHead, FX_DWORD nMax, FX_DWORD cbElement)

{

CFX_Plex* p = (CFX_Plex*)FX_Alloc(FX_BYTE, sizeof(CFX_Plex) + nMax * cbElement);

Lei Zhang 2015/05/15 23:44:17 Not going to check for overflows / convert to Allo

Tom Sepez 2015/05/18 16:04:30 Ah, this one didn't fit the model and should be cl

- if (!p) {

- return NULL;

- }

p->pNext = pHead;

pHead = p;

return p;