Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1143643003: [Chromoting] Add GN build support for ar_sample_app target. (Closed)

Created:
5 years, 7 months ago by garykac
Modified:
5 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Add GN build support for ar_sample_app target. This adds GN build rules for the AppRemoting sample app. Some DesktopRemoting build rules were prettified as part of this process (to make the App- and Desktop- remoting build rules more similar). This re-re-lands crrev.com/1126393002 without any additional changes required. The original issues with the GN clobber builds are fixed in crrev.com/1137753002. The 2nd attempt to land was rejected due to a merge race (fixed in this cl). BUG=471916 Committed: https://crrev.com/c1fd3a3d2e9c4f8117ab6650289cebc0bb9553e7 Cr-Commit-Position: refs/heads/master@{#330243}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -143 lines) Patch
M remoting/app_remoting_webapp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/app_remoting_webapp_build.gypi View 2 chunks +1 line, -1 line 0 comments Download
M remoting/remoting_client.gypi View 6 chunks +4 lines, -4 lines 0 comments Download
M remoting/remoting_version.gni View 7 chunks +7 lines, -7 lines 1 comment Download
M remoting/webapp/BUILD.gn View 3 chunks +15 lines, -93 lines 0 comments Download
M remoting/webapp/build-webapp.py View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/build_template.gni View 5 chunks +304 lines, -26 lines 0 comments Download
M remoting/webapp/files.gni View 9 chunks +121 lines, -11 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
garykac
Third time's a charm! Changes from last version noted. https://codereview.chromium.org/1143643003/diff/1/remoting/remoting_version.gni File remoting/remoting_version.gni (right): https://codereview.chromium.org/1143643003/diff/1/remoting/remoting_version.gni#newcode18 remoting/remoting_version.gni:18: ...
5 years, 7 months ago (2015-05-15 22:33:51 UTC) #2
Jamie
lgtm
5 years, 7 months ago (2015-05-15 22:39:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143643003/1
5 years, 7 months ago (2015-05-15 22:55:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-16 00:21:13 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:29:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1fd3a3d2e9c4f8117ab6650289cebc0bb9553e7
Cr-Commit-Position: refs/heads/master@{#330243}

Powered by Google App Engine
This is Rietveld 408576698