Source/modules/indexeddb/IDBObjectStore.cpp - Issue 114363002: Structured cloning: improve DataCloneError reporting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBObjectStore.cpp

Issue 114363002: Structured cloning: improve DataCloneError reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + reset V8TestInterfaceConstructor.cpp result Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/indexeddb/IDBObjectStore.cpp

diff --git a/Source/modules/indexeddb/IDBObjectStore.cpp b/Source/modules/indexeddb/IDBObjectStore.cpp

index 5eec9b0c3aedc7ac49e3720b8edb7e77281d58f7..e81440e387a14857f802d160bcdd12a5198f8cf9 100644

--- a/Source/modules/indexeddb/IDBObjectStore.cpp

+++ b/Source/modules/indexeddb/IDBObjectStore.cpp

@@ -167,10 +167,8 @@ PassRefPtr<IDBRequest> IDBObjectStore::put(WebIDBDatabase::PutMode putMode, Pass

return 0;

}

- // FIXME: Make SerializedScriptValue::create etc take an ExceptionState or use ScriptState::setDOMException.

- bool didThrow = false;

- RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValue::create(value, didThrow, state);

- if (didThrow)

+ RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValue::create(value, exceptionState, state);

+ if (exceptionState.hadException())

return 0;

if (serializedValue->containsBlobs()) {

« no previous file with comments | « Source/core/dom/MessagePort.cpp ('k') | Source/web/WebSerializedScriptValue.cpp » ('j') | no next file with comments »