Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: Source/bindings/v8/ExceptionState.h

Issue 114363002: Structured cloning: improve DataCloneError reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/v8/SerializedScriptValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ExceptionState.h
diff --git a/Source/bindings/v8/ExceptionState.h b/Source/bindings/v8/ExceptionState.h
index bfe2790e16a84ac1aa19d47d039b94074bdf9fe8..d86754138fc31c8261c5a095d4a5a558ea6e6420 100644
--- a/Source/bindings/v8/ExceptionState.h
+++ b/Source/bindings/v8/ExceptionState.h
@@ -106,6 +106,8 @@ public:
const char* propertyName() const { return m_propertyName; }
const char* interfaceName() const { return m_interfaceName; }
+ void setException(v8::Handle<v8::Value>);
Mike West 2013/12/13 21:22:59 Why is this now public? I don't see where you need
sof 2013/12/13 21:51:33 It's used to transfer the exception from the TryCa
Dmitry Lomov (no reviews) 2013/12/16 09:14:39 I think the naming of methods on ExceptionState is
+
protected:
ExceptionCode m_code;
Context m_context;
@@ -113,8 +115,6 @@ protected:
const char* m_interfaceName;
private:
- void setException(v8::Handle<v8::Value>);
-
String addExceptionContext(const String&) const;
ScopedPersistent<v8::Value> m_exception;
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/v8/SerializedScriptValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698