Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: Source/bindings/v8/custom/V8WorkerCustom.cpp

Issue 114363002: Structured cloning: improve DataCloneError reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + reset V8TestInterfaceConstructor.cpp result Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8WindowCustom.cpp ('k') | Source/core/dom/MessagePort.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 namespace WebCore { 43 namespace WebCore {
44 44
45 void V8Worker::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value> & info) 45 void V8Worker::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value> & info)
46 { 46 {
47 ExceptionState exceptionState(ExceptionState::ExecutionContext, "postMessage ", "Worker", info.Holder(), info.GetIsolate()); 47 ExceptionState exceptionState(ExceptionState::ExecutionContext, "postMessage ", "Worker", info.Holder(), info.GetIsolate());
48 Worker* worker = V8Worker::toNative(info.Holder()); 48 Worker* worker = V8Worker::toNative(info.Holder());
49 MessagePortArray ports; 49 MessagePortArray ports;
50 ArrayBufferArray arrayBuffers; 50 ArrayBufferArray arrayBuffers;
51 if (info.Length() > 1) { 51 if (info.Length() > 1) {
52 const int transferablesArgIndex = 1; 52 const int transferablesArgIndex = 1;
53 bool notASequence = false; 53 if (!extractTransferables(info[transferablesArgIndex], transferablesArgI ndex, ports, arrayBuffers, exceptionState, info.GetIsolate())) {
54 if (!extractTransferables(info[transferablesArgIndex], ports, arrayBuffe rs, notASequence, info.GetIsolate())) { 54 exceptionState.throwIfNeeded();
55 if (notASequence) {
56 exceptionState.throwTypeError(ExceptionMessages::notAnArrayTypeA rgumentOrValue(transferablesArgIndex + 1));
57 exceptionState.throwIfNeeded();
58 }
59 return; 55 return;
60 } 56 }
61 } 57 }
62 bool didThrow = false; 58 RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(info[0 ], &ports, &arrayBuffers, exceptionState, info.GetIsolate());
63 RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(info[0 ], &ports, &arrayBuffers, didThrow, info.GetIsolate()); 59 if (exceptionState.throwIfNeeded())
64 if (didThrow)
65 return; 60 return;
66 worker->postMessage(message.release(), &ports, exceptionState); 61 worker->postMessage(message.release(), &ports, exceptionState);
67 exceptionState.throwIfNeeded(); 62 exceptionState.throwIfNeeded();
68 } 63 }
69 64
70 } // namespace WebCore 65 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8WindowCustom.cpp ('k') | Source/core/dom/MessagePort.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698