Source/bindings/v8/custom/V8MessagePortCustom.cpp - Issue 114363002: Structured cloning: improve DataCloneError reporting.

Side by Side Diff: Source/bindings/v8/custom/V8MessagePortCustom.cpp

Issue 114363002: Structured cloning: improve DataCloneError reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + reset V8TestInterfaceConstructor.cpp result Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 30 matching lines...) Expand all Loading...
41	41

42 namespace WebCore {	42 namespace WebCore {

43	43

44 void V8MessagePort::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::V alue>& info)	44 void V8MessagePort::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::V alue>& info)

45 {	45 {

46 ExceptionState exceptionState(ExceptionState::ExecutionContext, "postMessage ", "MessagePort", info.Holder(), info.GetIsolate());	46 ExceptionState exceptionState(ExceptionState::ExecutionContext, "postMessage ", "MessagePort", info.Holder(), info.GetIsolate());

47 MessagePort* messagePort = V8MessagePort::toNative(info.Holder());	47 MessagePort* messagePort = V8MessagePort::toNative(info.Holder());

48 MessagePortArray portArray;	48 MessagePortArray portArray;

49 ArrayBufferArray arrayBufferArray;	49 ArrayBufferArray arrayBufferArray;

50 if (info.Length() > 1) {	50 if (info.Length() > 1) {

51 bool notASequence = false;

52 const int transferablesArgIndex = 1;	51 const int transferablesArgIndex = 1;

53 if (!extractTransferables(info[transferablesArgIndex], portArray, arrayB ufferArray, notASequence, info.GetIsolate())) {	52 if (!extractTransferables(info[transferablesArgIndex], transferablesArgI ndex, portArray, arrayBufferArray, exceptionState, info.GetIsolate())) {

54 if (notASequence) {	53 exceptionState.throwIfNeeded();

55 exceptionState.throwTypeError(ExceptionMessages::notAnArrayTypeA rgumentOrValue(transferablesArgIndex + 1));

56 exceptionState.throwIfNeeded();

57 }

58 return;	54 return;

59 }	55 }

60 }	56 }

61 bool didThrow = false;	57 RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(info[0 ], &portArray, &arrayBufferArray, exceptionState, info.GetIsolate());

62 RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(info[0 ], &portArray, &arrayBufferArray, didThrow, info.GetIsolate());	58 if (exceptionState.throwIfNeeded())

63 if (didThrow)

64 return;	59 return;

65 messagePort->postMessage(message.release(), &portArray, exceptionState);	60 messagePort->postMessage(message.release(), &portArray, exceptionState);

66 exceptionState.throwIfNeeded();	61 exceptionState.throwIfNeeded();

67 }	62 }

68	63

69 } // namespace WebCore	64 } // namespace WebCore

OLD	NEW

« no previous file with comments | « Source/bindings/v8/custom/V8HistoryCustom.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »