Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Side by Side Diff: Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp

Issue 114363002: Structured cloning: improve DataCloneError reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + reset V8TestInterfaceConstructor.cpp result Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8Utilities.cpp ('k') | Source/bindings/v8/custom/V8HistoryCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 #include "bindings/v8/V8Binding.h" 37 #include "bindings/v8/V8Binding.h"
38 #include "bindings/v8/V8Utilities.h" 38 #include "bindings/v8/V8Utilities.h"
39 #include "bindings/v8/V8WorkerGlobalScopeEventListener.h" 39 #include "bindings/v8/V8WorkerGlobalScopeEventListener.h"
40 #include "core/workers/DedicatedWorkerGlobalScope.h" 40 #include "core/workers/DedicatedWorkerGlobalScope.h"
41 #include "wtf/ArrayBuffer.h" 41 #include "wtf/ArrayBuffer.h"
42 42
43 namespace WebCore { 43 namespace WebCore {
44 44
45 void V8DedicatedWorkerGlobalScope::postMessageMethodCustom(const v8::FunctionCal lbackInfo<v8::Value>& info) 45 void V8DedicatedWorkerGlobalScope::postMessageMethodCustom(const v8::FunctionCal lbackInfo<v8::Value>& info)
46 { 46 {
47 ExceptionState exceptionState(ExceptionState::ExecutionContext, "postMessage ", "WorkerGlobalScope", info.Holder(), info.GetIsolate());
47 DedicatedWorkerGlobalScope* workerGlobalScope = V8DedicatedWorkerGlobalScope ::toNative(info.Holder()); 48 DedicatedWorkerGlobalScope* workerGlobalScope = V8DedicatedWorkerGlobalScope ::toNative(info.Holder());
48 MessagePortArray ports; 49 MessagePortArray ports;
49 ArrayBufferArray arrayBuffers; 50 ArrayBufferArray arrayBuffers;
50 if (info.Length() > 1) { 51 if (info.Length() > 1) {
51 const int transferablesArgIndex = 1; 52 const int transferablesArgIndex = 1;
52 bool notASequence = false; 53 if (!extractTransferables(info[transferablesArgIndex], transferablesArgI ndex, ports, arrayBuffers, exceptionState, info.GetIsolate())) {
53 if (!extractTransferables(info[transferablesArgIndex], ports, arrayBuffe rs, notASequence, info.GetIsolate())) { 54 exceptionState.throwIfNeeded();
54 if (notASequence)
55 throwTypeError(ExceptionMessages::failedToExecute("postMessage", "WorkerGlobalScope", ExceptionMessages::notAnArrayTypeArgumentOrValue(transfera blesArgIndex + 1)), info.GetIsolate());
56 return; 55 return;
57 } 56 }
58 } 57 }
59 bool didThrow = false; 58 RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(info[0 ], &ports, &arrayBuffers, exceptionState, info.GetIsolate());
60 RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(info[0 ], &ports, &arrayBuffers, didThrow, info.GetIsolate()); 59 if (exceptionState.throwIfNeeded())
61 if (didThrow)
62 return; 60 return;
63 ExceptionState exceptionState(info.Holder(), info.GetIsolate()); 61
64 workerGlobalScope->postMessage(message.release(), &ports, exceptionState); 62 workerGlobalScope->postMessage(message.release(), &ports, exceptionState);
65 exceptionState.throwIfNeeded(); 63 exceptionState.throwIfNeeded();
66 } 64 }
67 65
68 } // namespace WebCore 66 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8Utilities.cpp ('k') | Source/bindings/v8/custom/V8HistoryCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698