Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1143623002: [strong] Implement per-object restrictions behaviour for prototype setting (Closed)

Created:
5 years, 7 months ago by conradw
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Implement per-object restrictions behaviour for prototype setting Implements the strong mode proposal's restrictions on the ability of user code to modify the prototype of strong objects. Setting the strong bit is still wip, so this change will only affect those objects that have the bit correctly set. The tests reflect this, and will be expanded as more objects can be marked as strong. BUG=v8:3956 LOG=N Committed: https://crrev.com/629d2750732236b2ac128bd253b97928026d3435 Cr-Commit-Position: refs/heads/master@{#28664}

Patch Set 1 #

Patch Set 2 : fix nit #

Patch Set 3 : rebase to reposition error message declaration #

Patch Set 4 : fix commented out (for future) test #

Patch Set 5 : update tests, rebase #

Patch Set 6 : make sloppy func actually sloppy #

Patch Set 7 : in test, make sure type feedback is reset for each object #

Total comments: 6

Patch Set 8 : cl feedback #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M src/messages.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
A test/mjsunit/strong/object-set-prototype.js View 1 2 3 4 5 6 7 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
conradw
PTAL
5 years, 7 months ago (2015-05-15 14:18:56 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 7 months ago (2015-05-15 14:24:31 UTC) #4
rossberg
lgtm
5 years, 7 months ago (2015-05-18 13:47:52 UTC) #5
conradw
PTAL, updated
5 years, 7 months ago (2015-05-21 22:49:48 UTC) #7
rossberg
lgtm https://codereview.chromium.org/1143623002/diff/140001/src/messages.h File src/messages.h (right): https://codereview.chromium.org/1143623002/diff/140001/src/messages.h#newcode230 src/messages.h:230: T(StrongSetProto, "Cannot set internal prototype of strong object ...
5 years, 7 months ago (2015-05-22 12:56:45 UTC) #8
conradw
https://codereview.chromium.org/1143623002/diff/140001/src/messages.h File src/messages.h (right): https://codereview.chromium.org/1143623002/diff/140001/src/messages.h#newcode230 src/messages.h:230: T(StrongSetProto, "Cannot set internal prototype of strong object %") ...
5 years, 7 months ago (2015-05-22 13:49:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143623002/180001
5 years, 6 months ago (2015-05-27 17:01:43 UTC) #12
commit-bot: I haz the power
Committed patchset #9 (id:180001)
5 years, 6 months ago (2015-05-27 17:06:41 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-05-27 17:06:56 UTC) #14
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/629d2750732236b2ac128bd253b97928026d3435
Cr-Commit-Position: refs/heads/master@{#28664}

Powered by Google App Engine
This is Rietveld 408576698