Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6233)

Unified Diff: chrome/browser/media/router/media_sinks_observer.h

Issue 1143603004: [Media Router] Add Media Router Mojo impl code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Xiaohan's comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_sinks_observer.h
diff --git a/chrome/browser/media/router/media_sinks_observer.h b/chrome/browser/media/router/media_sinks_observer.h
index 0b7bb5eb792dcbb17d050ad8784aca9f8241871e..36037edbef12834f727c31b2eadae3c9a33797d6 100644
--- a/chrome/browser/media/router/media_sinks_observer.h
+++ b/chrome/browser/media/router/media_sinks_observer.h
@@ -28,6 +28,9 @@ class MediaSinksObserver {
// This function is invoked when the list of sinks compatible
// with |source_| has been updated.
+ // Implementations may not perform operations that modify the Media Router's
+ // observer list. In particular, invoking this observer's destructor within
+ // OnSinksReceived will result in undefined behavior.
virtual void OnSinksReceived(const std::vector<MediaSink>& sinks) {}
const MediaSource& source() const { return source_; }
« no previous file with comments | « chrome/browser/media/router/media_routes_observer.cc ('k') | chrome/browser/media/router/media_sinks_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698