Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: chrome/browser/media/router/media_routes_observer.h

Issue 1143603004: [Media Router] Add Media Router Mojo impl code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed wez's 3rd comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_routes_observer.h
diff --git a/chrome/browser/media/router/media_routes_observer.h b/chrome/browser/media/router/media_routes_observer.h
index b4faa60ab0b6ce2519f0336e4edfc960054cfc92..3123778582572154b031142d09f860c3fde15be3 100644
--- a/chrome/browser/media/router/media_routes_observer.h
+++ b/chrome/browser/media/router/media_routes_observer.h
@@ -24,6 +24,9 @@ class MediaRoutesObserver {
// This function is invoked when the list of routes and their associated
Wez 2015/05/26 23:41:30 nit: No need for "This function is"; can start wit
imcheng (use chromium acct) 2015/05/27 01:06:04 Done.
// sinks have been updated. Routes included in the list are created either
// locally or remotely.
Wez 2015/05/26 23:41:30 nit: "Routes included in the list..." - not clear
imcheng (use chromium acct) 2015/05/27 01:06:04 Done.
+ // Implementations may not perform operations that modifies the Media Router's
Wez 2015/05/26 23:41:30 s/modifies/modify
imcheng (use chromium acct) 2015/05/27 01:06:04 Done.
+ // observer list. In particular, invoking this instance's destructor within
Wez 2015/05/26 23:41:30 nit: s/instance/observer
imcheng (use chromium acct) 2015/05/27 01:06:04 Done.
+ // this method will result in undefined behavior.
Wez 2015/05/26 23:41:30 nit: s/this method/OnRoutesUpdated
imcheng (use chromium acct) 2015/05/27 01:06:04 Done.
virtual void OnRoutesUpdated(const std::vector<MediaRoute>& routes) {}
private:

Powered by Google App Engine
This is Rietveld 408576698