Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1143593007: Adds an OWNERS entry for SQLitePersistentCookieStore. (Closed)

Created:
5 years, 7 months ago by rohitrao (ping after 24h)
Modified:
5 years, 7 months ago
Reviewers:
erikchen, *Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds an OWNERS entry for SQLitePersistentCookieStore. Copies over the previous OWNER of this code, from before the code moved into net/extras/sqlite. BUG=None TEST=None Committed: https://crrev.com/a950149cca5431d7de4b29cc17afd15a11b38eb9 Cr-Commit-Position: refs/heads/master@{#330682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A net/extras/sqlite/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rohitrao (ping after 24h)
Does this look reasonable? I'm not sure if OWNERS should carry over to every file ...
5 years, 7 months ago (2015-05-19 22:35:44 UTC) #2
erikchen
On 2015/05/19 22:35:44, rohitrao wrote: > Does this look reasonable? I'm not sure if OWNERS ...
5 years, 7 months ago (2015-05-19 22:39:09 UTC) #3
rohitrao (ping after 24h)
+rsleevi I lost the original OWNER of the SQLitePersistentCookieStore when I moved it out of ...
5 years, 7 months ago (2015-05-19 22:42:14 UTC) #6
Ryan Sleevi
lgtm
5 years, 7 months ago (2015-05-20 00:22:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143593007/1
5 years, 7 months ago (2015-05-20 01:52:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 02:24:43 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 02:25:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a950149cca5431d7de4b29cc17afd15a11b38eb9
Cr-Commit-Position: refs/heads/master@{#330682}

Powered by Google App Engine
This is Rietveld 408576698