Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 1143593003: Reland "Disable user gesture checking for all autofill browser tests." (Closed)

Created:
5 years, 7 months ago by please use gerrit instead
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, glider+watch_chromium.org, rouslan+autofillwatch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Disable user gesture checking for all autofill browser tests." When drmemory_full runs, the browser tests are slowed down enough to timeout the user gesture indicator, which prevents autofill from processing the input and passing the browser test. The fix is to disable user gesture checking for all autofill browser tests except AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges. TBR=thestig@chromium.org,estade@chromium.org BUG=484910 Committed: https://crrev.com/42b0908760521c3b9a300d1a7c480f2bcc07a2d0 Cr-Commit-Position: refs/heads/master@{#330300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -11 lines) Patch
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 5 chunks +44 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 2 chunks +5 lines, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143593003/1
5 years, 7 months ago (2015-05-17 04:09:45 UTC) #2
please use gerrit instead
FYI, relanding after fixing the GN build.
5 years, 7 months ago (2015-05-17 04:10:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-17 05:04:44 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42b0908760521c3b9a300d1a7c480f2bcc07a2d0 Cr-Commit-Position: refs/heads/master@{#330300}
5 years, 7 months ago (2015-05-18 11:32:27 UTC) #5
Lei Zhang
lgtm In general, it would be nice to upload the previous CL as patch set ...
5 years, 7 months ago (2015-05-18 19:24:46 UTC) #6
please use gerrit instead
5 years, 7 months ago (2015-05-18 19:30:12 UTC) #7
Message was sent while issue was closed.
On 2015/05/18 19:24:46, Lei Zhang wrote:
> lgtm
> 
> In general, it would be nice to upload the previous CL as patch set 1, and the
> fix as patch set 2. So it's easy to tell what changed.

Good point, thank you. I will incorporate this into my workflow next time.

Powered by Google App Engine
This is Rietveld 408576698