Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1143523002: Refactoring Iterator used on SVGEnumeration. (Closed)

Created:
5 years, 7 months ago by hyunjunekim2
Modified:
5 years, 7 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, krit, kouhei+svg_chromium.org, f(malita), gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring Iterator used on SVGEnumeration. This CL is to clean up code. Change to for-each statement instead of for-iter. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195616

Patch Set 1 #

Patch Set 2 : for-each #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M Source/core/svg/SVGEnumeration.cpp View 1 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hyunjunekim2
pdr, fs, Could you check this patch? Thank you.
5 years, 7 months ago (2015-05-14 04:09:37 UTC) #2
fs
On 2015/05/14 04:09:37, hyunjunekim2 wrote: > pdr, fs, > Could you check this patch? Thank ...
5 years, 7 months ago (2015-05-18 09:11:25 UTC) #3
hyunjunekim2
fs, Could you check PS2?
5 years, 7 months ago (2015-05-20 12:18:16 UTC) #4
fs
lgtm
5 years, 7 months ago (2015-05-20 12:44:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143523002/20001
5 years, 7 months ago (2015-05-20 12:44:48 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 14:02:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195616

Powered by Google App Engine
This is Rietveld 408576698