Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Issue 1143503003: Use |IsOriginSecure| for mark-HTTP-nonsecure field trial (Closed)

Created:
5 years, 7 months ago by estark
Modified:
5 years, 7 months ago
Reviewers:
meacer
CC:
chromium-reviews, palmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use |IsOriginSecure| for mark-HTTP-nonsecure field trial When the flag or field trial is set such that non-secure origins will be marked as dubious/non-secure, use |IsOriginSecure| to determine whether an origin is non-secure, instead of simply treating http:// and ftp:// as non-secure. This means that http://nytimes.com will be marked as dubious/non-secure, but not http://localhost (for example). BUG=487499 TEST=Enable the "Mark non-secure as non-secure" flag in chrome://flags. Visit http://nytimes.com and observe that the lock icon is red and crossed out. Visit an http:// URL on localhost and observe that the lock icon is neutral. Committed: https://crrev.com/5f99677ac4f9b8180ee7fd2f0d5c85e91828a951 Cr-Commit-Position: refs/heads/master@{#329774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ssl/connection_security_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
estark
meacer: PTAL? palmer: FYI, as we discussed IRL earlier this week.
5 years, 7 months ago (2015-05-13 23:19:16 UTC) #2
meacer
LGTM
5 years, 7 months ago (2015-05-14 00:14:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143503003/1
5 years, 7 months ago (2015-05-14 00:19:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 01:36:59 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5f99677ac4f9b8180ee7fd2f0d5c85e91828a951 Cr-Commit-Position: refs/heads/master@{#329774}
5 years, 7 months ago (2015-05-14 01:38:41 UTC) #7
sergeyv
5 years, 7 months ago (2015-05-14 10:52:16 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1130843005/ by sergeyv@chromium.org.

The reason for reverting is: Android Tests dbg bot is failing:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)

The reason of this failure is following patch:
https://codereview.chromium.org/1123943002/

I had to revert this patch because it is a follow up..

Powered by Google App Engine
This is Rietveld 408576698