Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: remoting/webapp/crd/js/crd_auth_dialog.js

Issue 1143453007: remoting.WindowShape clean up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/base/js/window_shape_unittest.js ('k') | remoting/webapp/crd/js/desktop_remoting.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/crd_auth_dialog.js
diff --git a/remoting/webapp/crd/js/crd_auth_dialog.js b/remoting/webapp/crd/js/crd_auth_dialog.js
index 6cde0e87ae8e71bf4a16cfda01ee7dae486c3ca5..96b2b1099c3c992ca3a413ba530e5009ef67a280 100644
--- a/remoting/webapp/crd/js/crd_auth_dialog.js
+++ b/remoting/webapp/crd/js/crd_auth_dialog.js
@@ -13,7 +13,6 @@ var instance_ = null;
/**
* @constructor
- * @implements {remoting.WindowShape.ClientUI}
* @implements {remoting.Identity.ConsentDialog}
* @param {HTMLElement} rootElement The dialog DOM element.
* @private
@@ -32,20 +31,6 @@ remoting.AuthDialog = function(rootElement) {
this.onAuthButtonDeferred_ = null;
this.authButton_.addEventListener('click', this.onClick_.bind(this), false);
- remoting.windowShape.addCallback(this);
-};
-
-/**
- * @param {Array<{left: number, top: number, width: number, height: number}>}
- * rects List of rectangles.
- */
-remoting.AuthDialog.prototype.addToRegion = function(rects) {
- var rect =
- /** @type {ClientRect} */(this.borderElement_.getBoundingClientRect());
- rects.push({left: rect.left,
- top: rect.top,
- width: rect.width,
- height: rect.height});
};
/** @private */
@@ -53,7 +38,6 @@ remoting.AuthDialog.prototype.onClick_ = function() {
this.rootElement_.hidden = true;
this.onAuthButtonDeferred_.resolve(null);
this.onAuthButtonDeferred_ = null;
- remoting.windowShape.updateClientWindowShape();
};
/**
@@ -66,7 +50,6 @@ remoting.AuthDialog.prototype.show = function() {
}
this.rootElement_.hidden = false;
base.debug.assert(this.onAuthButtonDeferred_ === null);
- remoting.windowShape.updateClientWindowShape();
this.onAuthButtonDeferred_ = new base.Deferred();
return this.onAuthButtonDeferred_.promise();
};
« no previous file with comments | « remoting/webapp/base/js/window_shape_unittest.js ('k') | remoting/webapp/crd/js/desktop_remoting.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698