remoting/webapp/app_remoting/js/context_menu_dom.js - Issue 1143453007: remoting.WindowShape clean up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/app_remoting/js/context_menu_dom.js

Issue 1143453007: remoting.WindowShape clean up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer's feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/app_remoting/js/context_menu_dom.js

diff --git a/remoting/webapp/app_remoting/js/context_menu_dom.js b/remoting/webapp/app_remoting/js/context_menu_dom.js

index 0338e6fcb4adb128577e996847caff1224cbf265..48791b7f3b20852e62cc33339a36114fbeb61c08 100644

--- a/remoting/webapp/app_remoting/js/context_menu_dom.js

+++ b/remoting/webapp/app_remoting/js/context_menu_dom.js

@@ -74,7 +74,11 @@ remoting.ContextMenuDom = function(root) {

this.root_.hidden = false;

this.root_.style.bottom = this.bottom_ + 'px';

- remoting.windowShape.addCallback(this);

+ remoting.windowShape.registerClientUI(this);

+};

+remoting.ContextMenuDom.prototype.dispose = function() {

+ remoting.windowShape.unregisterClientUI(this);

};

/**