remoting.WindowShape clean up.

remoting.WindowShape clean up.

This CL
- Adds an unregister method to the remoting.WindowShape so that clientUI can unhook itself.
  This is a preparation work for the in-DOM reconnect window.
- Adds an centerToDesktop() method to center a DOM element to the union of desktop rectangle.

BUG=486888
Committed: https://crrev.com/41b04f38c37575dc66db8a6036be62f51adff209
Cr-Commit-Position: refs/heads/master@{#330576}

[kelvinp, 2015-05-18 23:19:37]

kelvinp@chromium.org changed reviewers:
+ garykac@chromium.org

[kelvinp, 2015-05-18 23:21:18]

PTAL

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/crd/js/crd_...
File remoting/webapp/crd/js/crd_auth_dialog.js (left):

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/crd/js/crd_...
remoting/webapp/crd/js/crd_auth_dialog.js:16: * @implements
{remoting.WindowShape.ClientUI}
WindowShape is not used in CRD at all.

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/crd/js/desk...
File remoting/webapp/crd/js/desktop_remoting.js (left):

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/crd/js/desk...
remoting/webapp/crd/js/desktop_remoting.js:122:
remoting.windowShape.updateClientWindowShape();
windowShape is not used in CRD.

[garykac, 2015-05-19 00:39:53]

lgtm with nits

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/context_menu_chrome.js (right):

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/context_menu_chrome.js:21:
remoting.ContextMenuChrome.prototype.dispose = function() {};
nit: blank line after

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/base/js/win...
File remoting/webapp/base/js/window_shape.js (right):

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/base/js/win...
remoting/webapp/base/js/window_shape.js:37: * Adds a client-side UI.
The other comments are active: "Center align the...", "Set the region...", "Add
the context menu...".

For consistency, this should remain "Add a client-side UI."

[kelvinp, 2015-05-19 17:46:34]

Thx. Fixed.
FYI

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/context_menu_chrome.js (right):

https://codereview.chromium.org/1143453007/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/context_menu_chrome.js:21:
remoting.ContextMenuChrome.prototype.dispose = function() {};
On 2015/05/19 00:39:53, garykac wrote:
> nit: blank line after

Done.

[kelvinp, 2015-05-19 17:47:01]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2015-05-19 17:47:02]

The patchset sent to the CQ was uploaded after l-g-t-m from garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/1143453007/#ps20001
(title: "Reviewer's feedback")

[commit-bot: I haz the power, 2015-05-19 17:49:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143453007/20001

[commit-bot: I haz the power, 2015-05-19 18:51:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-19 18:52:41]

Patchset 2 (id:??) landed as
https://crrev.com/41b04f38c37575dc66db8a6036be62f51adff209
Cr-Commit-Position: refs/heads/master@{#330576}