Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1143453005: [Media Router] Remove RouteIDManager. (Closed)

Created:
5 years, 7 months ago by imcheng (use chromium acct)
Modified:
5 years, 7 months ago
Reviewers:
Wez
CC:
chromium-reviews, posciak+watch_chromium.org, media-router+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Remove RouteIDManager. Remove RouteIDManager as it is not and will not be used. BUG=461815 Committed: https://crrev.com/980844d28489891f43a7271dd8b08eb933e01668 Cr-Commit-Position: refs/heads/master@{#330263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -92 lines) Patch
M chrome/browser/media/router/media_router.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/media/router/route_id_manager.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/media/router/route_id_manager.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/media/router/route_id_manager_unittest.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
imcheng (use chromium acct)
PTAL, thanks.
5 years, 7 months ago (2015-05-16 00:27:50 UTC) #2
Wez
lgtm
5 years, 7 months ago (2015-05-16 00:34:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143453005/1
5 years, 7 months ago (2015-05-16 00:36:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-16 01:49:37 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:30:43 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/980844d28489891f43a7271dd8b08eb933e01668
Cr-Commit-Position: refs/heads/master@{#330263}

Powered by Google App Engine
This is Rietveld 408576698