Fix MessageReader to pass errors to the channel

remoting/protocol/channel_multiplexer.h

Index: remoting/protocol/channel_multiplexer.h
diff --git a/remoting/protocol/channel_multiplexer.h b/remoting/protocol/channel_multiplexer.h
index cb18d3377fdfddbbe7262ab9cc86d76bb6c4a781..c406d9b27030ef3a738e3a4f15897566702d264c 100644
--- a/remoting/protocol/channel_multiplexer.h
+++ b/remoting/protocol/channel_multiplexer.h
@@ -44,11 +44,12 @@ class ChannelMultiplexer : public StreamChannelFactory {
   // Helper method used to create channels.
   MuxChannel* GetOrCreateChannel(const std::string& name);
 
-  // Error handling callback for |writer_|.
-  void OnWriteFailed(int error);
+  // Error handling callback for |reader_| and |writer_|.
+  void OnBaseChannelError(int error);

[Jamie, 2015/05/13 18:25:17]

Why not OnReadWriteFailed for consistency with the other rename you've done?

[Sergey Ulanov, 2015/05/14 00:15:21]

In multiplexer OnReadWriteFailed() doesn't make it clear where the error has
occurred.

 
-  // Failed write notifier, queued asynchronously by OnWriteFailed().
-  void NotifyWriteFailed(const std::string& name);
+  // Propagates base channel error to channel |name|, queued asynchronously by
+  // OnBaseChannelError().
+  void NotifyBaseChannelError(const std::string& name, int error);
 
   // Callback for |reader_;
   void OnIncomingPacket(scoped_ptr<MultiplexPacket> packet,