Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1143433003: Force immediate Mojo EDK shutdown on IO loop destruction. (Closed)

Created:
5 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 7 months ago
Reviewers:
Hajime Morrita, jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force immediate Mojo EDK shutdown on IO loop destruction. This is an addendum to r329262 which still didn't quite get it right. The assumption here is now that the IPCSupportInitializer must outlive the IO thread anyway, so the IO loop observer may (and should) call ForceShutdown immediately rather than posting a task. BUG=486004 R=jam@chromium.org Committed: https://crrev.com/5085101bae8a25ad039e1b48d721ddc081e64d17 Cr-Commit-Position: refs/heads/master@{#329692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M ipc/mojo/scoped_ipc_support.cc View 6 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
please take a look; pulled this out of the roll CL since it should actually ...
5 years, 7 months ago (2015-05-13 17:32:05 UTC) #1
Hajime Morrita
lgtm
5 years, 7 months ago (2015-05-13 17:50:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143433003/1
5 years, 7 months ago (2015-05-13 17:51:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 19:10:55 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:11:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5085101bae8a25ad039e1b48d721ddc081e64d17
Cr-Commit-Position: refs/heads/master@{#329692}

Powered by Google App Engine
This is Rietveld 408576698