Add validation infrastructure for "pub lish".

utils/pub/command_lish.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library command_lish;
 
 import 'dart:io';
 import 'dart:json';
 import 'dart:uri';
 
 import '../../pkg/args/lib/args.dart';
 import '../../pkg/http/lib/http.dart' as http;
 import 'pub.dart';
 import 'io.dart';
 import 'git.dart' as git;
 import 'oauth2.dart' as oauth2;
+import 'validator.dart';
 
 // TODO(nweiz): Make "publish" the primary name for this command. See issue
 // 6949.
 /// Handles the `lish` and `publish` pub commands.
 class LishCommand extends PubCommand {
   final description = "publish the current package to pub.dartlang.org";
   final usage = "pub publish [options]";
   final aliases = const ["lish", "lush"];
 
   ArgParser get commandParser {
     var parser = new ArgParser();
     parser.addOption('server', defaultsTo: 'https://pub.dartlang.org',
         help: 'The package server to which to upload this package');
     return parser;
   }
 
   /// The URL of the server to which to upload the package.
   Uri get server => new Uri.fromString(commandOptions['server']);
 
   Future onRun() {
     var cloudStorageUrl;
     return oauth2.withClient(cache, (client) {
       // TODO(nweiz): Cloud Storage can provide an XML-formatted error. We
       // should report that error and exit.
       return Futures.wait([
         client.get(server.resolve("/packages/versions/new.json")),
         _filesToPublish.transform((files) {
           return createTarGz(files, baseDir: entrypoint.root.dir);
-        }).chain(consumeInputStream)
+        }).chain(consumeInputStream),
+        _validate()
       ]).chain((results) {
         var response = results[0];
         var packageBytes = results[1];
         var parameters = _parseJson(response);
 
         var url = _expectField(parameters, 'url', response);
         if (url is! String) _invalidServerResponse(response);
         cloudStorageUrl = new Uri.fromString(url);
         var request = new http.MultipartRequest('POST', cloudStorageUrl);
 
@@ skipping 107 matching lines @@
   /// error if [map] doens't contain [key].
   _expectField(Map map, String key, http.Response response) {
     if (map.containsKey(key)) return map[key];
     _invalidServerResponse(response);
   }
 
   /// Throws an error describing an invalid response from the server.
   void _invalidServerResponse(http.Response response) {
     throw 'Invalid server response:\n${response.body}';
   }
+
+  /// Validates the package. Throws an exception if it's invalid.
+  Future _validate() {
+    return Validator.runAll(entrypoint).chain((pair) {
+      var errors = pair.first;
+      var warnings = pair.last;
+
+      if (errors.isEmpty && warnings.isEmpty) return new Future.immediate(null);
+      if (!errors.isEmpty) throw "Package validation failed.";
+
+      var s = warnings.length == 1 ? '' : 's';
+      stdout.writeString("Package has ${warnings.length} warning$s. Upload "
+          "anyway (y/n)? ");
+      return readLine().transform((line) {
+        if (new RegExp(r"^[yY]").hasMatch(line)) return;
+        throw "Package upload canceled.";
+      });
+    });
+  }
 }