Geolocation request for Google Now

chrome/browser/ui/google_now/google_now_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_GOOGLE_NOW_GOOGLE_NOW_SERVICE_H_
 #define CHROME_BROWSER_UI_GOOGLE_NOW_GOOGLE_NOW_SERVICE_H_
 
 #include "base/timer.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
 
@@ skipping 34 matching lines @@
   // Gets new cards from the server and shows them as notifications.
   void UpdateCards();
 
   // Schedules next cards update after the specified delay.
   void StartWaitingForNextUpdate(base::TimeDelta delay);
   void OnWaitingForNextUpdateEnds();
 
   // Starts obtaining location of the machine.
   void StartObtainingGeolocation();
   void OnLocationObtained(const content::Geoposition& position);
+  void OnLocationRequestTimeout();
 
-  // Starts downloading cards from the server.
+  // Starts downloading cards from the server. If the position's Validate() call

[bulach, 2012/12/10 14:25:46]

nit: not sure if the last bit add much in here :) I mean, for any
content::Geoposition object, Validate() being false means it's not available...

[vadimt, 2012/12/10 19:09:08]

Done.

+  // returns false, this means that the position is not available.
   void StartServerRequest(const content::Geoposition& position);
   void OnServerRequestCompleted(net::URLRequest* request, int num_bytes);
 
   // Parses server response. Returns true if the parsing was successful.
   static bool ParseServerResponse(const net::URLRequest* request,
                                   int num_bytes,
                                   ServerResponse* server_response);
 
   // Shows Google Now cards as notifications.
   void ShowNotifications(const ServerResponse& server_response);
 
   // The profile.
   Profile* const profile_;
   // Timer to schedule next cards update.
   base::OneShotTimer<GoogleNowService> next_update_timer_;
+  // Timer to cancel geolocation requests that take too long.
+  base::OneShotTimer<GoogleNowService> geolocation_request_timer_;
+  // Weak factory for the geolocation request callback. Used to ensure
+  // geolocation request callback is not run after this object is destroyed.
+  base::WeakPtrFactory<GoogleNowService> geolocation_request_weak_factory_;

[John Knottenbelt, 2012/12/10 14:30:58]

nit: I read this as "a factory that hands out weak pointers to geolocation
requests". It might be clearer to name it just weak_factory_.

[vadimt, 2012/12/10 19:09:08]

Probably, we'll have other weak pointers here, for other kinds of asynchronous
requests. So, if you don't mind, I'll leave it as is. Thanks for the comment!

 
   DISALLOW_COPY_AND_ASSIGN(GoogleNowService);
 };
 
 #endif  // CHROME_BROWSER_UI_GOOGLE_NOW_GOOGLE_NOW_SERVICE_H_