Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11434111: Clamp texture queries to sane values. (Closed)

Created:
8 years ago by brianderson
Modified:
8 years ago
CC:
chromium-reviews, cc-bugs_chromium.org, vangelis, wiltzius
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Clamp texture queries to sane values. Some device's concept of time might be off. To prevent corrupt texture runtime measurements from corrupting the texture upload logic, we clamp the runtimes to the range of [1,15000] microseconds. If the corrupt runtimes are 0, this patch will effectively cause us to always upload all pending textures. This is a workaround until the async texture upload feature lands. BUG=162699 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171108

Patch Set 1 #

Total comments: 1

Patch Set 2 : Increase upper limit of a query #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/texture_uploader.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reveman
maybe make the upper limit a bit higher, otherwise lgtm. https://codereview.chromium.org/11434111/diff/1/cc/texture_uploader.cc File cc/texture_uploader.cc (right): https://codereview.chromium.org/11434111/diff/1/cc/texture_uploader.cc#newcode358 ...
8 years ago (2012-12-04 21:24:09 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years ago (2012-12-04 21:34:45 UTC) #2
nduca
lgtm
8 years ago (2012-12-04 21:37:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/11434111/3002
8 years ago (2012-12-04 21:44:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/11434111/3002
8 years ago (2012-12-04 21:45:44 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-05 01:08:40 UTC) #6
Message was sent while issue was closed.
Change committed as 171108

Powered by Google App Engine
This is Rietveld 408576698